[HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [$250] Validate account-After entering magic code from Connect online with Plaid, manual set up opens

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.57-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): yonghongkok2+22skdpsdkok@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Sign up as a new Gmail user
3. Complete onboarding
4. Create a new workspace
5. Go to workspace settings > More features
6. Enable Workflows
7. Go to Workflows
8. Click Connect bank account
9. Click Connect online with Plaid
10. Enter magic code

Expected Result:

After entering magic code from Connect online with Plaid, Plaid page will open

Actual Result:

After entering magic code from Connect online with Plaid, "Manually add bank account" page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6655471_1730812610903.bandicam_2024-11-05_21-10-35-451.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853831016472532052
• Upwork Job ID: 1853831016472532052
• Last Price Increase: 2024-11-05

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-11-05 15:00:09 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After entering magic code from Connect online with Plaid, manual set up opens

What is the root cause of that problem?

Here we set the subset to MANUAL That is why after verification we navigate to manual page

App/src/pages/ReimbursementAccount/BankAccountStep.tsx

Line 184 in b914945

selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL;

I can see that this is also wrong the below code should be MANUAL

App/src/pages/ReimbursementAccount/BankAccountStep.tsx

Line 201 in b914945

selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID;

What changes do you think we should make in order to solve the problem?

Change this to CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID

App/src/pages/ReimbursementAccount/BankAccountStep.tsx

Line 184 in b914945

selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL;

Optional: Change the below to MANUAL

App/src/pages/ReimbursementAccount/BankAccountStep.tsx

Line 201 in b914945

selectedSubStep.current = CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID;

What alternative solutions did you explore? (Optional)

[Julesssss]

Hey @Nodebrute, ah nice spot, It does seem likey they are inverted. Are you able to raise a PR now?

[Nodebrute]

@Julesssss On it.