[HOLD for payment 2025-01-13] [$250] Implement tests for reports that should not be displayed in LHN

[OlimpiaZurek]

Tracking issue: #52031.

Develop and implement tests to verify that the following report types are not displayed in the Left-Hand Navigation (LHN):

1. Hidden report: Ensure reports marked as hidden do not appear in the LHN.
2. Report with no participants: Validate that chats without participants are excluded from the LHN.
3. Access restricted report: Confirm that reports the user cannot access due to policy restrictions are not shown.
4. Single transaction thread: Ensure that reports containing only one transaction are excluded from the LHN.
5. Empty chat: Verify that empty chats, when the excludeEmptyChats setting is true, are not displayed.
6. Domain email exclusion: Check that reports are excluded when the user’s email is domain-based and the setting is false.
7. Parent message pending removal: Confirm that reports with parent messages pending removal do not appear in the LHN.
8. Focus Mode without unread messages: Ensure that when the user is in focus mode without unread messages, no reports are displayed.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021862798689700375032
• Upwork Job ID: 1862798689700375032
• Last Price Increase: 2024-11-30
• Automatic offers:
• c3024 | Reviewer | 105210430
• mkzie2 | Contributor | 105210431

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

Moving to Weekly since we are on hold for App#52036

---

Heads up, I will be offline until Tuesday, November 12, 2024, and will not actively watch over this GitHub during that period.

[alexpensify]

Still on hold for App#52036

[alexpensify]

On hold

[andriivitiv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Implement tests for reports that should not be displayed in LHN.

What is the root cause of that problem?

This is the first time we're adding these tests.

What changes do you think we should make in order to solve the problem?

Example of 1 test for reference:

it('should not display hidden report', async () => {
    // When the SidebarLinks are rendered.
    await LHNTestUtils.getDefaultRenderedSidebarLinks();
    const report = createReport({isHidden: false});

    // And a non-hidden report is initialized in Onyx.
    await initializeState(false, {
        [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
    });

    // Then the report should appear in the sidebar.
    expect(getOptionRows()).toHaveLength(1);

    // When the report is hidden.
    await act(async () => {
        await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`, {isHidden: true});
    });

    // Then the report should not appear in the sidebar.
    expect(getOptionRows()).toHaveLength(0);
});

A few more can be found on my test branch. It also includes fixes for console errors that appeared while running these tests, e.g. missing key prop and missing act() calls.

Todo: check not only for the count of reports but also validate the name, etc.