[HOLD for payment 2024-12-05] [$250] Trackpad gestures for navigation history does not work in Newdot

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.55-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1730106001602619

Action Performed:

1. Open ND on web chrome (Macos), navigate to different pages, to. build navigation history.
2. Swipe right with 2 fingers on trackpad to navigate back

Expected Result:

It navigate back to previous page like other apps

Actual Result:

Nothing happens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.3168.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852208286215064025
• Upwork Job ID: 1852208286215064025
• Last Price Increase: 2024-11-08

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2-finger swipe gesture doesn't work in web.

What is the root cause of that problem?

The gesture doesn't work because we disable the overscroll-behavior here.

App/web/index.html

Lines 37 to 41 in fe779d9

	body {
	overflow: hidden;
	overscroll-behavior: none;
	touch-action: none;
	}

This was added in #15100 to specifically not allow the body to be scrollable on iOS safari.

What changes do you think we should make in order to solve the problem?

We should disable the overscroll-behavior (and touch-action if needed) for iOS safari only. First, remove it from here.

App/web/index.html

Lines 37 to 41 in fe779d9

	body {
	overflow: hidden;
	overscroll-behavior: none;
	touch-action: none;
	}

Then, add a new selector style to disable overscroll-behavior.

body.disable-overscroll {
    overscroll-behavior: none;
}

Last, apply the class to the body if it's mobile safari. (we can apply this in App.tsx)

if (isMobileSafari()) document.body.classList.add('disable-overscroll')

What alternative solutions did you explore? (Optional)

Remove the overscroll-behavior and touch-action hack just like we remove the opacity hack from #15100 in #18266.

[VictoriaExpensify]

Reproduced the issue. I agree this is a problem we should fix

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021852208286215064025

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

@mananjadhav, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!