[HOLD for payment 2024-11-21] [$250] Remove the `New Workspace` option from Global Create for members of existing group workspace.

[JmillsExpensify]

Proposal: Remove the New Workspace option from Global Create for members of existing group workspace.

Background: Thousands of existing OldDot members land in NewDot on a daily basis, whether to interact with services like Guides, Account Managers (AMs), or Concierge. Once in NewDot, Full Story sessions reveal that members commonly explore our new product and the features available.

Problem: When submit employees that already belong to a existing group workspace see the New Workspace option, they unintentionally create more workspaces, which causes confusion and prevents them from submitting expenses to their employer.

Solution: Remove the New Workspace option from Global Create for all members that already belong to a group workspace – streamlining their experience by reducing confusion and preventing accidental workspace creation. Additionally, we’ll universally promote a single way to create your second, third, fourth or an infinite number of workspaces via one centralized flow in Settings > Workspaces.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851027135757622934
• Upwork Job ID: 1851027135757622934
• Last Price Increase: 2024-10-28
• Automatic offers:
• nkdengineer | Contributor | 104766386

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851027135757622934

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[Krishna2323]

@JmillsExpensify, is there any way to reproduce this with a new email?

[NJ-2020]

Edited by proposal-police: This proposal was edited at 2024-11-05 23:01:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove the New Workspace option from Global Create for members of existing group workspace

What is the root cause of that problem?

New feature
We only hide the New workspace button from Global action if the user has any active enabled chat policies

App/src/libs/actions/Policy/Policy.ts

Lines 249 to 255 in db592c9

	/**
	* Check if the user has any active free policies (aka workspaces)
	*/
	function hasActiveChatEnabledPolicies(policies: Array<OnyxEntry<PolicySelector>> | OnyxCollection<PolicySelector>, includeOnlyAdminPolicies = false): boolean {
	const chatEnabledPolicies = Object.values(policies ?? {}).filter(
	(policy) => policy?.isPolicyExpenseChatEnabled && (!includeOnlyAdminPolicies || policy.role === CONST.POLICY.ROLE.ADMIN),
	);

What changes do you think we should make in order to solve the problem?

Based on this #51616 (comment) , we can check if the policy type is team or corporate then we will simply return true

const chatEnabledPolicies = Object.values(policies ?? {}).filter(
    (policy) => policy?.type === CONST.POLICY.TYPE.TEAM || policy?.type === CONST.POLICY.TYPE.CORPORATE && (!includeOnlyAdminPolicies || policy.role === CONST.POLICY.ROLE.ADMIN),
);

Or we can also do this

const chatEnabledPolicies = Object.values(policies ?? {}).filter(
    (policy) => policy?.type === CONST.POLICY.TYPE.TEAM || policy?.type === CONST.POLICY.TYPE.CORPORATE,
);

What alternative solutions did you explore? (Optional)

We can check if the policy type is not personal then we will return true

const chatEnabledPolicies = Object.values(policies ?? {}).filter(
    (policy) => policy?.type !== CONST.POLICY.TYPE.PERSONAL,
);