[HOLD for payment 2024-11-20] [$250] Duplicate system message when resolving duplicates selecting "Keep all"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1729791374775059

Action Performed:

1. Create a workspace as user A
2. Add user B to the workspace
3. Submit duplicate expenses to the workspace
4. As user A resolve the duplicate expenses by selecting "Keep all"

Expected Result:

Only one system message "resolved the duplicate" appears

Actual Result:

Duplicate resolved the duplicate message appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.703.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849911355476934677
• Upwork Job ID: 1849911355476934677
• Last Price Increase: 2024-10-25

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849911355476934677

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[JmillsExpensify]

Opening up to the community to see if we can get this long-standing bug fixed.

[ranli]

Edited by proposal-police: This proposal was edited at 2024-10-28 07:23:31 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Duplicate system message("resolved the duplicate") when resolving duplicates selecting "Keep all"

What is the root cause of that problem?

In src/libs/actions/Transaction.ts file, dismissDuplicateTransactionViolation() function keeps adding same reporting actions whenever user review and select "keep all" a new submitted duplicate expense. This is because we are using${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${action?.childReportID ?? '-1'} as the key, so same action get added everytime.

  const optimisticReportActions: OnyxUpdate[] = transactionsReportActions.map((action, index) => ({
      onyxMethod: Onyx.METHOD.MERGE,
      key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${action?.childReportID ?? '-1'}`,
      value: {
          [optimisticDissmidedViolationReportActions.at(index)?.reportActionID ?? '']: optimisticDissmidedViolationReportActions.at(index) as ReportAction,
      },
  }));

What changes do you think we should make in order to solve the problem?

Append the violation type to the key, so the same violation wont be added twice.

const optimisticReportActions: OnyxUpdate[] = transactionsReportActions.map((action, index) => ({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${action?.childReportID ?? '-1'}_${CONST.VIOLATIONS.DUPLICATED_TRANSACTION}`,
    value: {
        [optimisticDissmidedViolationReportActions.at(index)?.reportActionID ?? '']: optimisticDissmidedViolationReportActions.at(index) as ReportAction,
    },
}));
....
const failureReportActions: OnyxUpdate[] = transactionsReportActions.map((action, index) => ({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${action?.childReportID ?? '-1'}_${CONST.VIOLATIONS.DUPLICATED_TRANSACTION}`,
    value: {
        [optimisticDissmidedViolationReportActions.at(index)?.reportActionID ?? '']: null,
    },
}));
...
const successData: OnyxUpdate[] = transactionsReportActions.map((action, index) => ({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${action?.childReportID ?? '-1'}_${CONST.VIOLATIONS.DUPLICATED_TRANSACTION}`,
    value: {
        [optimisticDissmidedViolationReportActions.at(index)?.reportActionID ?? '']: {
            pendingAction: null,
        },
    },
}));

...

What alternative solutions did you explore? (Optional)

1. Add a attribute the report action type, so that we can use a dynamic value as the key. This will impact many places, as report action is used by many other components. regression may happen.
2. Filter the action at view level (ReportActionItem component). This component has many business logic, filtering may also cause regression.

Contributor details

Your Expensify account email: ranli.ryan@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0184337af0a7f3752b

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[ranli]

Contributor details
Your Expensify account email: ranli.ryan@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0184337af0a7f3752b

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.