[HOLD for payment 2024-11-13] [$250] Workflows - Edit approval workflow becomes blank after editing it offline and returning online

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows.
3. Enable Add approvals.
4. Go offline.
5. Click on the existing approval workflow.
6. Click Approval.
7. Select another member and click Save.
8. Click Save again.
9. Click on the same workflow.
10. Go online.

Expected Result:

Edit approval workflow will not become blank after returning online.

Actual Result:

Edit approval workflow becomes blank after editing it offline and returning online.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6645399_1729851090815.20241025_180844.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851096096588176267
• Upwork Job ID: 1851096096588176267
• Last Price Increase: 2024-10-29
• Automatic offers:
• FitseTLT | Contributor | 104666575

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #wave-control

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-10-25 13:34:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workflows - Edit approval workflow becomes blank after editing it offline and returning online

What is the root cause of that problem?

We are re-setting APPROVAL_WORKFLOW on success data here

App/src/libs/actions/Workflow.ts

Lines 175 to 179 in a86ee35

	const successData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.SET,
	key: ONYXKEYS.APPROVAL_WORKFLOW,
	value: null,

so when we go online and the request completes successfully it deletes approval workflow so we see blank page as there is nothing to show

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx

Lines 135 to 136 in a86ee35

	{approvalWorkflow && (
	<>

What changes do you think we should make in order to solve the problem?

APPROVAL_WORKFLOW is where we save the draft approval workflow until we save the workflow so no need to reset it in success data it should be reset in optimistic data immediately so that it would be used by the next approval modification
We should remove the successData and failureData for APPROVAL_WORKFLOW and only reset it in optimistic data here

App/src/libs/actions/Workflow.ts

Lines 143 to 145 in a86ee35

	key: ONYXKEYS.APPROVAL_WORKFLOW,
	value: {
	isLoading: true,

            value: null,

We should do the same in other places like here
here
isLoading is unnecessary and we will remove it from APPROVAL_WORKFLOW

What alternative solutions did you explore? (Optional)

[melvin-bot]

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[VictoriaExpensify]

Oh yes, this is a problem and we should fix it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851096096588176267