[HOLD for payment 2024-11-20] [Simple AA in NewDot] Submit to category and tag approvers

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/430318

Action Performed:

1. Create Control policy, with "Manual" scheduled submit, with Advanced Approvals enabled
2. Submitter submitsTo policy owner
3. Approver A set as Category Approver for Category CAT_APPROVER
4. Submitter creates expense in workspace chat w/ Category CAT_APPROVER
5. Submitter submits report

Expected Result:

Next manager (approver) should be Approver A

Actual Result:

Error, since we try to submit the report to policy owner (submitter's submitsTo)

Solution Guideline

In PolicyUtils.getSubmitToAccountID, for policies on CONST.POLICY.APPROVAL_MODE.ADVANCED, we currently assume that we should submit to employee.submitsTo ?? defaultApprover`.

However, in OldDot you'll notice that we actually want to submit the report to the category or tag approver before considering the submitter's submitsTo.

So we can either update getSubmitToAccountID to account for those additional approvers (assuming no other related regressions) OR we might have to create a new function for getting the "next submitter" in this case - the assigned contrib should evaluate existing uses of getSubmitToAccountID before determining which solution to follow

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[melvin-bot]

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-10-17 11:15:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error, since we try to submit the report to policy owner (submitter's submitsTo)

What is the root cause of that problem?

This is a new feature request.

What changes do you think we should make in order to solve the problem?

All places where we're using getSubmitToAccountID function are getting the submitsTo for an expense report then I think we can update the getSubmitToAccountID to cover the addition approver rule case.

1. We can change employeeAccountID param to expenseReport and we will replace all use of employeeAccountID in this function to expenseReport.ownerAccountID

App/src/libs/PolicyUtils.ts

Line 517 in 987ff1b

function getSubmitToAccountID(policy: OnyxEntry<Policy>, employeeAccountID: number): number {

2. If the advanced workflow is enabled we will get the details of the first transaction of expenseReport. I think the first transaction will decide which user the the submitsTo of this expense.

3. Getting the approver for the category/tag of all transactions (if category/tag isn't empty) by using the same function here to find the first transaction that has an approver match with the category or the first transaction that has an approver match with the tag (if we don't have any transaction match with the category)

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 83 in 987ff1b

const categoryApprover = CategoryUtils.getCategoryApproverRule(policy?.rules?.approvalRules ?? [], categoryName)?.approver ?? '';

If the approver exists we should return this approver otherwise return employee.submitsTo ?? defaultApprover

Here is an example update for getSubmitToAccountID function

function getSubmitToAccountID(policy: OnyxEntry<Policy>, expenseReport: Report): number {
    const employeeAccountID = expenseReport?.ownerAccountID ?? -1;
    const employeeLogin = getLoginsByAccountIDs([employeeAccountID]).at(0) ?? '';
    const defaultApprover = getDefaultApprover(policy);

    // For policy using the optional or basic workflow, the manager is the policy default approver.
    if (([CONST.POLICY.APPROVAL_MODE.OPTIONAL, CONST.POLICY.APPROVAL_MODE.BASIC] as Array<ValueOf<typeof CONST.POLICY.APPROVAL_MODE>>).includes(getApprovalWorkflow(policy))) {
        return getAccountIDsByLogins([defaultApprover]).at(0) ?? -1;
    }

   let categoryAppover;
    let tagApprover;
    const allTransactions = getAllReportTransactions(expenseReport.reportID).sort((transA, transB) => (transA.created < transB.created ? -1 : 1));

    for (let i = 0; i < allTransactions.length; i++) {
        const {tag = '', category = ''} = getTransactionDetails(allTransactions.at(i)) ?? {};
        categoryAppover = getCategoryApproverRule(policy?.rules?.approvalRules ?? [], category)?.approver;
        if (categoryAppover) {
            return categoryAppover;
        }

        if (!tagApprover && getTagApproverRule(policy?.id ?? '-1', tag)?.approver) {
            tagApprover = getTagApproverRule(policy?.id ?? '-1', tag)?.approver;
        } 
    }

    const employee = policy?.employeeList?.[employeeLogin];
    if (!employee) {
        return -1;
    }

    return getAccountIDsByLogins([tagApprover ?? employee.submitsTo ?? defaultApprover]).at(0) ?? -1;
}

OPTIONAL: If we want to use this function to find the submit to of an employee of the WS in the feature we can keep this function and create a new function for expense reports.

4. After updating this function completely, we need to update all places that we use this function to pass a new parameter

What alternative solutions did you explore? (Optional)