[HOLD for payment 2024-11-14] [$250] The amout page is flickered when editing the amount

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729061814164789

Action Performed:

1. Submit an expense to a DM or a WS chat
2. Open the combine report or open the transaction thread report
3. Click on the amount to open the edit page

Expected Result:

The amount page isn't flickered

Actual Result:

The amount page is flickered

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-10-16.at.13.53.42.mov

az_recorder_20241016_170141.1.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848569049299479731
• Upwork Job ID: 1848569049299479731
• Last Price Increase: 2024-10-29

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount field flickers on edit page, due to quick currency changes.

What is the root cause of that problem?

On the IOURequestStepAmount page, within the ReportUtils.getTransactionDetails function, we pass the transaction value. If isEditing is true, we use draftTransaction as the transaction value. However, when the page first loads, draftTransaction is undefined, causing getTransactionDetails to return null. In this case, we fall back to {currency: CONST.CURRENCY.USD}, which leads to the USD currency being displayed initially. On the second render, when draftTransaction is retrieved from Onyx, the correct original currency is shown. This results in the flickering effect where the amount switches from USD to the original currency.

What changes do you think we should make in order to solve the problem?

To Fix this, instead of just checking the isEditing condition before passing draftTransaction to getTransactionDetails, we should ensure that draftTransaction has a non empty value. This can be done by adding !isEmptyObject(draftTransaction) along with the isEditing check to avoid passing an empty object.

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 88 in 0b3569a

const {currency: originalCurrency} = ReportUtils.getTransactionDetails(isEditing ? draftTransaction : transaction) ?? {currency: CONST.CURRENCY.USD};

const {currency: originalCurrency} = ReportUtils.getTransactionDetails(isEditing && !isEmptyObject(draftTransaction) ? draftTransaction : transaction) ?? {currency: CONST.CURRENCY.USD};

What alternative solutions did you explore? (Optional)

[hayes102]

Wow a proposal in the same minute

[melvin-bot]

📣 @hayes102! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The amount is flickered when opening edit amount page

What is the root cause of that problem?

The weird bug happens by the old HOC withOnyx in IOURequestStepAmount. That causes the currency to flicker from USD to the current currency

Screen.Recording.2024-10-03.at.15.10.49.mov

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 334 in 927b40d

const IOURequestStepAmountWithOnyx = withOnyx<IOURequestStepAmountProps, IOURequestStepAmountOnyxProps>({

That is because the withOnyx is outdated and on Android, there are more delays on the other platform when we merge the Onyx data which can affect the weird lifecycle on Android.

We can see the log here in IOURequestStepAmount, this component is mounted and unmounted two times when we open this page

What changes do you think we should make in order to solve the problem?

Remove withOnyx in IOURequestStepAmount and use useOnyx. The test branch here

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 334 in 927b40d

const IOURequestStepAmountWithOnyx = withOnyx<IOURequestStepAmountProps, IOURequestStepAmountOnyxProps>({

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2024-10-03.at.15.07.32.mov

[jayeshmangwani]

@nkdengineer Your last commit was 15 days ago on the branch, but this issue was opened just 15 minutes ago. How is that possible?

Also, I tested with useOnyx, and draftTransaction value was undefined the first time

[nkdengineer]

@jayeshmangwani I proposed this bug in another issue that isn't this bug.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848569049299479731