[HOLD for payment 2024-11-14] [$250] Split - App crashes when opening user profile from split preview RHP offline then online

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5083991
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Create a group chat with users that have no chat history.
4. Split an expense.
5. Click on the split preview.
6. Click on any split participant to open the profile.
7. Go online.
8. Wait until it crashes.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6635031_1728983494310.20241015_170501.mp4

1510_1.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846204527381661299
• Upwork Job ID: 1846204527381661299
• Last Price Increase: 2024-10-22
• Automatic offers:
• alitoshmatov | Reviewer | 104617499
• nkdengineer | Contributor | 104617500

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-10-15 10:05:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when opening user profile from split preview RHP offline then online

What is the root cause of that problem?

The report.parentReportID is changed from empty string to undefined after the API is complete, and then the app crashes here

App/src/pages/home/report/withReportAndReportActionOrNotFound.tsx

Line 41 in b4b5965

const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report ? report.parentReportID : '-1'}`);

What changes do you think we should make in order to solve the problem?

We should update like this

 const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID ? report.parentReportID : '-1'}`); 

App/src/pages/home/report/withReportAndReportActionOrNotFound.tsx

Line 41 in b4b5965

const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report ? report.parentReportID : '-1'}`);

We should do the same for parentReportAction

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when creating a new group and open a split bill details while offline then turn online.

What is the root cause of that problem?

The app crashes because the useOnyx key of the parentReport here changes from a collection key (report_) to a collection member key (report_undefined).

App/src/pages/home/report/withReportAndReportActionOrNotFound.tsx

Lines 40 to 41 in b4b5965

	const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${props.route.params.reportID}`);
	const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report ? report.parentReportID : '-1'}`);

The parentReport relies on the report parentReportID. When we create a new group chat, we already passed undefined as the parentReportID.

App/src/libs/ReportUtils.ts

Lines 5359 to 5375 in b4b5965

	return buildOptimisticChatReport(
	participantAccountIDs,
	reportName,
	CONST.REPORT.CHAT_TYPE.GROUP,
	undefined,
	undefined,
	undefined,
	undefined,
	undefined,
	undefined,
	notificationPreference,
	undefined,
	undefined,
	undefined,
	avatarUri,
	avatarFilename,
	optimisticReportID,

But because it defaults to an empty string, an empty string of parentReportID is set.

App/src/libs/ReportUtils.ts

Line 5293 in b4b5965

parentReportID = '',

So, the onyx key will be report_. When the API is success, the parentReportID attribute is removed, so accessing it leads to undefined value (report_undefined).

What changes do you think we should make in order to solve the problem?

We should change the default value to undefined instead of empty string.

App/src/libs/ReportUtils.ts

Line 5293 in b4b5965

parentReportID = '',

parentReportID = undefined,

We can optionally update/simplify this

App/src/pages/home/report/withReportAndReportActionOrNotFound.tsx

Line 41 in b4b5965

const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report ? report.parentReportID : '-1'}`);

App/src/pages/home/report/withReportAndReportActionOrNotFound.tsx

Line 47 in b4b5965

const [parentReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '-1'}`, {

const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID || '-1'}`);
const [parentReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.parentReportID || '-1'}`, {

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846204527381661299

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[luckydaniel1993]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when opening user profile from split preview RHP offline then online

What is the root cause of that problem?

The app crashes because the useOnyx key of the parentReport and reportActions here changes from a collection key (report_, reportActions_) to a collection member key (report_undefined, reportActions_undefined).

App/src/pages/home/report/withReportAndReportActionOrNotFound.tsx

Line 41 in b4b5965

const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report ? report.parentReportID : '-1'}`);

App/src/pages/home/report/withReportAndReportActionOrNotFound.tsx

Line 47 in b4b5965

const [parentReportAction] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '-1'}`, {

What changes do you think we should make in order to solve the problem?

I changed the Ternary (Conditional) Operator for avoiding 'report_undefined' and 'reportActions_undefined' and it works fine.

What alternative solutions did you explore? (Optional)

We can't use '-1' for key. I tested with key as 'report_-1' and 'reportActions_-1' and app crashed.

Contributor details

Your Expensify account email: anasup1995@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

[melvin-bot]

📣 @anaslancer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>