[HOLD for payment 2025-01-30] [$250] Expense - After editing expense details, page not scrolled and focused to system message

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open 1:1 chat
3. Submit an expense
4. Enter description and merchant

Expected Result:

After editing expense details, page must be scrolled and focused to system message.

Actual Result:

After editing expense details, page not scrolled and focused to system message.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6631952_1728660268703.screenrecorder-2024-10-11-18-34-05-385_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021845669426671518848
• Upwork Job ID: 1845669426671518848
• Last Price Increase: 2025-01-13

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After editing expense details, page not scrolled and focused to system message.

What is the root cause of that problem?

We don't notifyNewAction when updating all fields of money request

App/src/libs/actions/IOU.ts

Line 5574 in 1220039

API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_AMOUNT_AND_CURRENCY, params, onyxData);

What changes do you think we should make in order to solve the problem?

We should call notifyNewAction to scroll to the bottom after we edit the money request

Report.notifyNewAction(transactionThreadReportID, Report.getCurrentUserAccountID(), params.reportActionID);

App/src/libs/actions/IOU.ts

Line 5574 in 1220039

API.write(WRITE_COMMANDS.UPDATE_MONEY_REQUEST_AMOUNT_AND_CURRENCY, params, onyxData);

OPTIONAL: We can check if the transaction thread report is one transaction thread we will notifyNewAction to parentReport

We should do the same for other update money request functions.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021845669426671518848

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)