[HOLD for payment 2024-11-01] [$250] TransitionOD-ND - When disabling tax in OD, ND "page not Found", "Back" takes to WS selection

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.46-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5053996
Issue reported by: Applause - Internal Team

Action Performed:

1. Open ND App
2. Create a WS
3. Log in as the same user in OD
4. In OD Click on Workspaces
5. Select the same WS as in ND
6. In OD go to WS settings and enable Tax
7. In ND go to WS settings, on LHP click on Tax icon
   8.With Tax page open in ND, navigate to OD and disable Tax option

Expected Result:

In ND the user is navigated to the LHP/WS editor page

Actual Result:

The user is shown "Ops...It's not here" page, the "Back" button takes you back to the WS selection page(User leaves the WS editor page)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6628416_1728397298522.taxdisablestaging.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021845793851841023680
• Upwork Job ID: 1845793851841023680
• Last Price Increase: 2024-10-14

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Going back from not found tax page leads to workspace list page.

What is the root cause of that problem?

When we disable the tax page, it's expected that a full screen not found page will show. The reason pressing back leads to the workspace list page is because a Navigation.dismissModal is called, which closes the workspace details page.

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 88 to 97 in 5d25b40

	function PageNotFoundFallback({policyID, shouldShowFullScreenFallback, fullPageNotFoundViewProps, isMoneyRequest}: PageNotFoundFallbackProps) {
	return (
	<NotFoundPage
	shouldForceFullScreen={shouldShowFullScreenFallback}
	onBackButtonPress={() => {
	if (shouldShowFullScreenFallback) {
	Navigation.dismissModal();
	return;
	}
	Navigation.goBack(policyID && !isMoneyRequest ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined);

What changes do you think we should make in order to solve the problem?

shouldShowFullScreenFallback is true if the feature is disabled or the policy is not accessible.

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 169 in 5d25b40

shouldShowFullScreenFallback={!isFeatureEnabled || isPolicyNotAccessible}

I think we should only close the workspace detail page if the policy is not accessible. To do that, we need to pass both isFeatureEnabled and isPolicyNotAccessible to PageNotFoundFallback and remove the shouldShowFullScreenFallback props and instead, add it as a local variable in PageNotFoundFallback.

isFeatureEnabled={isFeatureEnabled}
isPolicyNotAccessible={isPolicyNotAccessible}

Then, in PageNotFoundCallback,

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 88 to 98 in 5d25b40

	function PageNotFoundFallback({policyID, shouldShowFullScreenFallback, fullPageNotFoundViewProps, isMoneyRequest}: PageNotFoundFallbackProps) {
	return (
	<NotFoundPage
	shouldForceFullScreen={shouldShowFullScreenFallback}
	onBackButtonPress={() => {
	if (shouldShowFullScreenFallback) {
	Navigation.dismissModal();
	return;
	}
	Navigation.goBack(policyID && !isMoneyRequest ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined);
	}}

only use dismissModal if the policy is not accessible. If the feature is disabled, then we will just go back.

const shouldShowFullScreenFallback = !isFeatureEnabled || isPolicyNotAccessible;
onBackButtonPress={() => {
    if (isPolicyNotAccessible) {
        Navigation.dismissModal();
        return;
    }
    Navigation.goBack(policyID && !isMoneyRequest ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined);
}}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021845793851841023680

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)