[HOLD for payment 2024-10-25] [$250] [QBO] There is no option to enter credentials.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.45-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728292694875429

Action Performed:

1. Go to Workspace => Accounting.
2. Connect your workspace with QBO.
3. From QBO dashboard, disconnect Expensify App.
4. Go back to ND, click the menu from the Accounting page => Sync now.
5. Notice that's an error shows. Click threedot menu again, notice that you won't see Enter credentials option.

Expected Result:

If there's an authentication error, we should have Enter credentials option from three dot menu.

Actual Result:

There's no Enter credentials option even when we have authentication error.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-10-07.at.16.17.53.mov

Recording.634.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Recording.634.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844020791272244172
• Upwork Job ID: 1844020791272244172
• Last Price Increase: 2024-10-09
• Automatic offers:
• layacat | Contributor | 104419097

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no option to enter credentials

What is the root cause of that problem?

We don't enter credentials for qbo but we still show sync now button even if we have authentication error

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 118 to 125 in 1649496

	: [
	{
	icon: Expensicons.Sync,
	text: translate('workspace.accounting.syncNow'),
	onSelected: () => syncConnection(policyID, connectedIntegration),
	disabled: isOffline,
	},
	]),

What changes do you think we should make in order to solve the problem?

IMO we should hide the sync now button when we have an authentication error and only show the disconnect button. We can do something like this(pseudo-code)

   // Conditionally add Sync Now button if isAuthenticationError is false
        ...(!isAuthenticationError(policy, connectedIntegration) && !shouldShowEnterCredentials
            ? [
                  {
                      icon: Expensicons.Sync,
                      text: translate('workspace.accounting.syncNow'),
                      onSelected: () => syncConnection(policyID, connectedIntegration),
                      disabled: isOffline,
                  },
              ]
            : []),

Note

This is just pseudo-code we can make this more error-proof by adding more checks. We can refine the code further in the PR. We can also fix this for Xero

What alternative solutions did you explore? (Optional)

We can push a new button instead of sync now (for cases where we have an authentication error) if the user clicks on it, the user should be navigated to the QuickBooks website.

[layacat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no option to enter credentials for QBO and I think for Xero as well

What is the root cause of that problem?

We're hiding the Enter credentials button in here for Xero and QBO, which caused this issue:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Line 107 in bcc6263

...(shouldShowEnterCredentials && (connectedIntegration === CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT || connectedIntegration === CONST.POLICY.CONNECTIONS.NAME.NETSUITE)

What changes do you think we should make in order to solve the problem?

We should remove this check from the condition above:

 (connectedIntegration === CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT || connectedIntegration === CONST.POLICY.CONNECTIONS.NAME.NETSUITE) 

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[hungvu193]

Hi @dylanexpensify, I reported this issue also have good amount of context since I worked on QBO, Xero and reviewed credentials PR. I'm happy to take this one as C+

[dylanexpensify]

Sounds great @hungvu193 !

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844020791272244172

[melvin-bot]

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

[hungvu193]

Thanks for the proposals, everyone! It's clear that we shouldn't hide the Enter credentials option for both Xero and QBO.
@layacat 's proposal here has the correct RCA and straightforward solution.

🎀 👀 🎀 C+ reviewed