[HOLD for payment 2024-10-17] [$250] Closing the receipt image user lands in transaction thread instead of expense report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727915131329509

Action Performed:

1. Submit receipt expense
2. Make sure you had no other expenses on processing reports before
3. Wait for it to scan
4. On web, navigate to the workspace chat
5. Navigate to the expense report
6. Click on the receipt detail
7. Close the attachment modal
8. Note that you are not on the transaction thread report and not in the expense report

Expected Result:

You should remain on the one-expense report view of the expense report

Actual Result:

After going to the receipt detail, user is on the transaction thread which is confusing because the comments from the expense report are not visible

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-10-03.at.01.52.53.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841980614903369906
• Upwork Job ID: 1841980614903369906
• Last Price Increase: 2024-10-03
• Automatic offers:
• situchan | Contributor | 104256847
• nkdengineer | Contributor | 104263005

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After closing the receipt page, user redirects the user to the transaction thread report.

What is the root cause of that problem?

When we open the receipt page, the report is the transaction thread report then use dismissModal with reportID param is the transaction thread report so we go back to the transaction thread report if we close this page.

App/src/pages/TransactionReceiptPage.tsx

Line 54 in efa3274

Navigation.dismissModal(report?.reportID ?? '-1');

What changes do you think we should make in order to solve the problem?

We can simply use dismissModal without reportID or use goBack in this case

const onModalClose = () => {
    Navigation.dismissModal();
};

App/src/pages/TransactionReceiptPage.tsx

Line 54 in efa3274

Navigation.dismissModal(report?.reportID ?? '-1');

or we can check if the transaction thread is one transaction thread then we will pass reportID as report.parentReportID

Navigation.dismissModal(
    ReportUtils.isOneTransactionThread(report?.reportID ?? '-1', report?.parentReportID ?? '-1', parentReportAction) ? report?.parentReportID : report?.reportID,
);

App/src/pages/TransactionReceiptPage.tsx

Line 54 in efa3274

Navigation.dismissModal(report?.reportID ?? '-1');

What alternative solutions did you explore? (Optional)

Or we can pass backTo param when we open the TransactionReceiptPage and then we will go back to the backTo param if it exists otherwise dismiss the modal

App/src/pages/TransactionReceiptPage.tsx

Line 54 in efa3274

Navigation.dismissModal(report?.reportID ?? '-1');

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841980614903369906

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)