[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+sd34@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a manual expense.
4. Click Submit it to someone from the actionable whisper.
5. Click Just track it (don’t submit it).
6. Click Track expense.

Expected Result:

In Step 5, the option "Just track it (don’t submit it)" should not be present when submitting track expense to someone.

Actual Result:

In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone.
When selecting the option, it ends up tracking the expense again to self DM and this leads to infinite loading and RBR in LHN.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6622007_1727865495696.track_again.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-10-02 11:27:10 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone.
When selecting the option, it ends up tracking the expense again to self DM and this leads to infinite loading and RBR in LHN.

What is the root cause of that problem?

We are only not showing this option if the selfDMReportID is empty

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 79 in 9627f5f

const shouldDisplayTrackExpenseButton = !!selfDMReportID;

What changes do you think we should make in order to solve the problem?

We should add the check IOUUtils.isMovingTransactionFromTrackExpense to prevent showing this option if we're moving transaction from track expense

const shouldDisplayTrackExpenseButton = !!selfDMReportID && !IOUUtils.isMovingTransactionFromTrackExpense(action);

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 79 in 9627f5f

const shouldDisplayTrackExpenseButton = !!selfDMReportID;

What alternative solutions did you explore? (Optional)

[nkdengineer]

Regression from #49007