[HOLD for payment 2024-10-17] [$250] Expense - In archived workspace, tapping receipt replace directs to hmm not here page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Pre-Condition:

1. Create a expense with receipt in workspace chat

2. Delete the workspace

3. Launch app

4. Open archived workspace chat

5. Open the expense -- receipt

6. Tap 3 dots -- replace

Expected Result:

In archived workspace, tapping receipt replace option if not allowed must not be shown or otherwise user must be allowed to replace but page must not direct to hmm not here

Actual Result:

In archived workspace, tapping receipt replace directs to hmm not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6617820_1727468168310.Screenrecorder-2024-09-28-01-39-08-890_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021840979900027304765
• Upwork Job ID: 1840979900027304765
• Last Price Increase: 2024-10-01
• Automatic offers:
• suneox | Reviewer | 104253142
• Krishna2323 | Contributor | 104253143

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-09-28 14:41:57 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Expense - In archived workspace, tapping receipt replace directs to hmm not here page

What is the root cause of that problem?

readonly prop doesn't include !canEditReceipt condition.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 510 to 524 in 71db3f1

	{hasReceipt && (
	<View style={styles.moneyRequestViewImage}>
	<ReportActionItemImage
	thumbnail={receiptURIs?.thumbnail}
	fileExtension={receiptURIs?.fileExtension}
	isThumbnail={receiptURIs?.isThumbnail}
	image={receiptURIs?.image}
	isLocalFile={receiptURIs?.isLocalFile}
	filename={receiptURIs?.filename}
	transaction={updatedTransaction ?? transaction}
	enablePreviewModal
	readonly={readonly}
	/>
	</View>
	)}

What changes do you think we should make in order to solve the problem?


• Add !canEditReceipt to readonly prop. readonly={readonly || !canEditReceipt}.
• We can also use enablePreviewModal to disable the preview modal when !canEditReceipt is true.

What alternative solutions did you explore? (Optional)

• We can add !!ReportUtils.canUserPerformWriteAction(report) check inside TransactionReceiptPage.
  

  App/src/pages/TransactionReceiptPage.tsx

  Line 31 in 71db3f1

  const canEditReceipt = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT);

const canEditReceipt = !!ReportUtils.canUserPerformWriteAction(report) && ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT);

• Or we can add || !canUserPerformWriteAction(moneyRequestReport) in the condition below.
  

  App/src/libs/ReportUtils.ts

  Lines 3087 to 3089 in 71db3f1

  	if (isSettled(String(moneyRequestReport.reportID)) || isReportApproved(String(moneyRequestReport.reportID))) {
  	return false;
  	}

• If we decide to do that, then we can remove canUserPerformWriteAction from most of the places below, we should do some testing before removing the canUserPerformWriteAction check.
  

  App/src/components/ReportActionItem/MoneyRequestView.tsx

  Lines 161 to 175 in 71db3f1

  	// Flags for allowing or disallowing editing an expense
  	// Used for non-restricted fields such as: description, category, tag, billable, etc...
  	const canUserPerformWriteAction = !!ReportUtils.canUserPerformWriteAction(report) && !readonly;
  	const canEdit = ReportActionsUtils.isMoneyRequestAction(parentReportAction) && ReportUtils.canEditMoneyRequest(parentReportAction, transaction) && canUserPerformWriteAction;
  	const canEditTaxFields = canEdit && !isDistanceRequest;
  	const canEditAmount = canUserPerformWriteAction && ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.AMOUNT);
  	const canEditMerchant = canUserPerformWriteAction && ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.MERCHANT);
  	const canEditDate = canUserPerformWriteAction && ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DATE);
  	const canEditReceipt = canUserPerformWriteAction && ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT);
  	const hasReceipt = TransactionUtils.hasReceipt(updatedTransaction ?? transaction);
  	const isReceiptBeingScanned = hasReceipt && TransactionUtils.isReceiptBeingScanned(updatedTransaction ?? transaction);
  	const didReceiptScanSucceed = hasReceipt && TransactionUtils.didReceiptScanSucceed(transaction);
  	const canEditDistance = canUserPerformWriteAction && ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE);
  	const canEditDistanceRate = canUserPerformWriteAction && ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE);

Result

[Krishna2323]

Proposal Updated

• Added alternative

[Krishna2323]

Proposal Updated

• Minor update in the alternative section

[adelekennedy]

reproduced

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021840979900027304765