[HOLD for payment 2024-10-30] [$250] [Dupe detection] Report header has "Hold" action when the expense is already in Hold status

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48522
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [Employee] Submit two same expenses in the workspace chat.
3. [Admin] Go to any of the submitted expense in the workspace chat.
4. [Admin] Go offline.
5. [Admin] Click Review duplicates.
6. [Admin] Click Keep this one (any).
7. [Admin] Click Confirm on the confirmation page.
8. [Admin] Go to the other transaction thread that has "Hold" action in the expense preview.
9. [Admin] Click on the report header.

Expected Result:

Since the other expense has "Hold" action, the report header should have the "Unhold" action.

Actual Result:

The report header has "Hold" action when the expense is already in Hold status.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6617758_1727464896179.20240928_031804.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021840780088904015602
• Upwork Job ID: 1840780088904015602
• Last Price Increase: 2024-09-30

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

On prod, the other expense vanishes instantly

bandicam.2024-09-28.00-52-50-976.mp4

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[roryabraham]

Dupe detection is behind a beta w/ only internal users and developers, this is NAB