[HOLD for payment 2025-02-05] [$250] Actionable whisper: the "New message" floating button appears when it shouldn't

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @paultsimura
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727286146850839

Action Performed:

1. Create a room;
2. Mention a user that is not a member of this room using the @{user} syntax;
3. Notice the actionable whisper "Heads up, {user} isn't a member of this room" message appears;
4. Click "Do nothing"

Expected Result:

1. Create a room;
2. Mention a user that is not a member of this room using the @{user} syntax;
3. Notice the actionable whisper "Heads up, {user} isn't a member of this room" message appears;
4. Click "Do nothing"

Actual Result:

The "New messages" floating button appears.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug_2.mov

Recording.587.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839703879939232277
• Upwork Job ID: 1839703879939232277
• Last Price Increase: 2024-09-27
• Automatic offers:
• ishpaul777 | Reviewer | 104253570

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The New message shows after selecting Do nothing of an actionable mention whisper

What is the root cause of that problem?

In this issue, the New message shows because hasNewestReportAction is false.

App/src/pages/home/report/ReportActionsList.tsx

Lines 627 to 631 in 33818a9

	const canScrollToNewerComments = !isLoadingInitialReportActions && !hasNewestReportAction && sortedReportActions.length > 25 && !isLastPendingActionIsDelete;
	return (
	<>
	<FloatingMessageCounter
	isActive={(isFloatingMessageCounterVisible && !!unreadMarkerReportActionID) || canScrollToNewerComments}

hasNewestReportAction compares if the report lastVisibileActionCreated equals the newest action created.

App/src/pages/home/report/ReportActionsList.tsx

Line 282 in 33818a9

const hasNewestReportAction = sortedVisibleReportActions[0]?.created === report.lastVisibleActionCreated;

When we resolve the actionable mention whisper, we optimistically update the report lastVisibleActionCreated to the previous action created.

App/src/libs/actions/Report.ts

Line 3815 in 33818a9

const reportUpdateDataWithPreviousLastMessage = ReportUtils.getReportLastMessage(reportId, optimisticReportActions as ReportActions);

However, the sortedVisibleReportActions here still contains the resolved actionable mention whisper.

App/src/pages/home/report/ReportActionsList.tsx

Line 282 in 33818a9

const hasNewestReportAction = sortedVisibleReportActions[0]?.created === report.lastVisibleActionCreated;

We already filter here to filter out any action that shouldn't be visible, but the resolved whisper is not included.

App/src/pages/home/report/ReportActionsList.tsx

Lines 191 to 198 in 33818a9

	sortedReportActions.filter(
	(reportAction) =>
	(isOffline ||
	ReportActionsUtils.isDeletedParentAction(reportAction) ||
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
	reportAction.errors) &&
	ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),
	),

The reason the resolved whisper is not shown in the chat is because we manually return null if it's resolved.

App/src/pages/home/report/ReportActionItem.tsx

Lines 875 to 878 in 33818a9

	// If action is actionable whisper and resolved by user, then we don't want to render anything
	if (isActionableWhisper && (hasResolutionInOriginalMessage ? originalMessage.resolution : null)) {
	return null;
	}

What changes do you think we should make in order to solve the problem?

Instead of manually return null when the whisper action is resolved, we should filter it out early here by including it in shouldReportActionBeVisible.

App/src/pages/home/report/ReportActionsList.tsx

Lines 191 to 198 in 4c76858

	sortedReportActions.filter(
	(reportAction) =>
	(isOffline ||
	ReportActionsUtils.isDeletedParentAction(reportAction) ||
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
	reportAction.errors) &&
	ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),
	),

const originalMessage = getOriginalMessage(reportAction);
const isOriginalMessageAnObject = originalMessage && typeof originalMessage === 'object';
const hasResolutionInOriginalMessage = isOriginalMessageAnObject && 'resolution' in originalMessage;
const isActionableWhisper = isActionableMentionWhisper(reportAction) || isActionableTrackExpense(reportAction) || isActionableReportMentionWhisper(reportAction);
if (isActionableWhisper && (hasResolutionInOriginalMessage ? originalMessage.resolution : null)) {
    return false;
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839703879939232277

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[ishpaul777]

Reviewing 👀

[ishpaul777]

@bernhardoj's Proposal makes sense 👍 and works well

🎀 👀 🎀 C+ reviewed

Screen.Recording.2024-09-27.at.10.32.32.PM.mov

[ishpaul777]

🎀 👀 🎀 C+ reviewed ^