Search-New SearchButton has not been added

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #49379

Action Performed:

1. Verify that the button to trigger new search is displayed on every page
2. Verify that clicking the button opens new search router
3. Verify that search router works - it should navigate to search with specific query

Expected Result:

The button to trigger new search is displayed

Actual Result:

The button to trigger a new search is not displayed on any screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6615496_1727310749542.49379-mWeb.mp4

Bug6615496_1727310749548.49379-Web.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New SearchButton has not been added

What is the root cause of that problem?

We only show search button in development mode

App/src/libs/Permissions.ts

Lines 60 to 62 in da37289

	function canUseNewSearchRouter() {
	return Environment.isDevelopment();
	}

What changes do you think we should make in order to solve the problem?

If search button development is complete and we are ready to use it. we can remove this code block

App/src/libs/Permissions.ts

Lines 60 to 62 in da37289

	function canUseNewSearchRouter() {
	return Environment.isDevelopment();
	}

What alternative solutions did you explore? (Optional)

[Kicu]

The displaying of new Search button only in dev was a deliberate decision. It was impossible to work on the new SearchRouter without merging some code to main first, but we were not able to implement the whole Search 2.4 solution in one go - it was too complex.

We can enable the new Search button after these are merged:

• Search Page input: [Search v2.4] Update Search results page (Search bar only) #49462
• followup to ☝️ add display name replacement and make search page router editable #49838
• Search router List Add recent serches and recent chats in Search router #49457

Without these PRs the search v2.4 offers quite inferior experience in my opinion.
FYI @luacmartins please take a look

[luacmartins]

I agree. We can just close this issue, we'll add the button once the feature is ready