[Payment 2024-11-07] [$250] mWeb - Group chat - Not here page appears briefly when last member leave the group chat

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4985233&group_by=cases:section_id&group_order=asc&group_id=229067
Email or phone of affected tester (no customers): gocemate+a2197@gmail.com
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Create a group chat
2. Click on the header
3. Remove all existing members from the group
4. Click Leave the group
5. Confirm leaving the group participant

Expected Result:

There should be no error page

Actual Result:

Not here page appears briefly when last member leave the group chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6608577_1726732763600.Recording__3970.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836833773766101729
• Upwork Job ID: 1836833773766101729
• Last Price Increase: 2024-10-10
• Automatic offers:
• wildan-m | Contributor | 104431872

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-09-19 14:29:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Group chat - Not here page appears briefly when last member leave the group chat

What is the root cause of that problem?

We dismissModal and then call the leaveGroupChat here

App/src/pages/ReportDetailsPage.tsx

Lines 222 to 225 in 3657a67

	Navigation.dismissModal();
	Navigation.isNavigationReady().then(() => {
	if (isRootGroupChat) {
	Report.leaveGroupChat(report.reportID);

We are deleting the report optimistically before navigating to recent chat in leaveGroupChat

App/src/libs/actions/Report.ts

Line 2795 in 3657a67

navigateToMostRecentReport(report);

hence if the navigation is not quick enough we will see a not found page as the group chat is deleted in onyx

What changes do you think we should make in order to solve the problem?

We should execute the deleting code after the navigateToMostRecentReport has finished.
We can do that by either calling navigateToMostRecentReport first and call the optimistic code and api call after/in

1. isNavigationReady
2. InteractionManager.runAfterInteractions
3. after some custom set timeout

A similar method can used for leaveRoom too.

What alternative solutions did you explore? (Optional)

[dominictb]

Edited by proposal-police: This proposal was edited at 2024-09-19 17:43:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page appears briefly when last member leave the group chat

What is the root cause of that problem?

We're waiting for dismissModal navigation to trigger Report.leaveGroupChat(report.reportID)

so we can see the not found page for a shot time

What changes do you think we should make in order to solve the problem?

1. After dismissModal, we should call goBack to remove the group/thread chat (because that group/thread will be deleted). We just did the same in here

    const leaveChat = useCallback(() => {
        Navigation.dismissModal();
        Navigation.goBack()
        Navigation.isNavigationReady().then(() => {

2. Then Report.leaveGroupChat(report.reportID) will open the latest report

Change

App/src/libs/actions/Report.ts

Line 2739 in 10ea08e

Navigation.goBack(lastAccessedReportRoute);

to

Navigation.navigate(lastAccessedReportRoute);

3. We need to remove these lines since we already goBack before

What alternative solutions did you explore? (Optional)

We can consider to remove Navigation.isNavigationReady() in here. I tested this issue and the bug that needs isNavigationReady and they worked well

Result

Screen.Recording.2024-09-26.at.15.33.14.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836833773766101729

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

Reviewing..