[HOLD for payment 2024-10-25] [$250] Invoice - Invoice room is not archived after deleting the workspace offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #48275
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User B has only one workspace.

1. Go to staging.new.expensify.com
2. {User A] Send an invoice to User B.
3. [User B] Pay the invoice using Pay as a business option.
4. [User B] Go offline.
5. [User B] Delete the workspace.
6. {User B] Go to invoice chat.

Expected Result:

The invoice chat should be archived after deleting the workspace offline.

Actual Result:

The invoice room is not archived after deleting the workspace offline.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601022_1726146959362.20240912_210831.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841806197088184582
• Upwork Job ID: 1841806197088184582
• Last Price Increase: 2024-10-10
• Automatic offers:
• dukenv0307 | Reviewer | 104360901

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[IuliiaHerets]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The invoice room is not archived after deleting the workspace offline.

What is the root cause of that problem?

When deleting workspaces, we choose what report to be archived here:

App/src/libs/actions/Policy/Policy.ts

Lines 312 to 314 in 7748eff

	const reportsToArchive = Object.values(ReportConnection.getAllReports() ?? {}).filter(
	(report) => report?.policyID === policyID && (ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)),
	);

However, an invoice sent from user A will have policyID of A's WS, not of B's WS, so the condition report?.policyID === policyID is false, hence the chat room not archived.

What changes do you think we should make in order to solve the problem?

We should add logic to include invoice chat sent from others as well, like what we did here

Update this:

App/src/libs/actions/Policy/Policy.ts

Line 313 in 7748eff

(report) => report?.policyID === policyID && (ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)),

to:

(report) =>
            (report?.policyID === policyID || (report?.invoiceReceiver && 'policyID' in report?.invoiceReceiver && report?.invoiceReceiver.policyID == policyID)) &&
            (ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)),
    

What alternative solutions did you explore? (Optional)

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

reviewing today!

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[dylanexpensify]

@davidcardoza can you confirm if this is unexpected behavior?