[HOLD for payment 2024-10-08] [$75] Migrate withWritableReportOrNotFound from withOnyx to useOnyx

[roryabraham]

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1725973460005309?thread_ts=1725905735.105989&cid=C01GTK53T8Q

Migrate src/pages/iou/request/step/withWritableReportOrNotFound.tsx to use useOnyx instead of withOnyx.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834285173135937117
• Upwork Job ID: 1834285173135937117
• Last Price Increase: 2024-09-12
• Automatic offers:
• brunovjk | Reviewer | 103949076

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834285173135937117

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[melvin-bot]

Upwork job price has been updated to $75

[abhinaybathina]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate from withOnyx HOC to useOnyx hook

What is the root cause of that problem?

withOnyx HOC is deprecated

What changes do you think we should make in order to solve the problem?

Whatever props are coming from withOnyx HOC in withWritableReportOrNotFound should be replaced with useOnyx hook

What alternative solutions did you explore? (Optional)

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-12 17:55:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate withWritableReportOrNotFound from withOnyx to useOnyx

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

We can remove withOnyx from here
and use useOnyx

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID || -1}`);
    const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP);
    const [reportDraft] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_DRAFT}${reportID || -1}`);

Optional: we can also remove type props related to these.
Note: we might need to do some cleanup

What alternative solutions did you explore? (Optional)

We can remove withOnyx from here
and use useOnyx

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID ?? -1}`);
    const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP);
    const [reportDraft] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_DRAFT}${reportID ?? -1}`);