[HOLD for payment 2024-10-16] [$75] Migrate withReportOrNotFound from withOnyx to useOnyx

[roryabraham]

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1725973460005309?thread_ts=1725905735.105989&cid=C01GTK53T8Q

Migrate src/pages/home/report/withReportOrNotFound.tsx to use useOnyx instead of withOnyx.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834284536815669432
• Upwork Job ID: 1834284536815669432
• Last Price Increase: 2024-09-12
• Automatic offers:
• shubham1206agra | Reviewer | 103949135
• Tony-MK | Contributor | 103949136
• DylanDylann | Contributor | 104254755

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834284536815669432

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

Upwork job price has been updated to $75

[abhinaybathina]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate from withOnyx HOC to useOnyx hook

What is the root cause of that problem?

withOnyx HOC is deprecated

What changes do you think we should make in order to solve the problem?

Whatever props are coming from withOnyx HOC should be replaced with useOnyx hook

What alternative solutions did you explore? (Optional)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate withReportOrNotFound from withOnyx to useOnyx

What is the root cause of that problem?

A new feature

What changes do you think we should make in order to solve the problem?

We need to migrate the withOnyx here to use useOnyx. We also need to make sure the key we pass to useOnyx will be the collection member key to prevent the app crashes.

After using useOnyx, we can remove the type here

App/src/pages/home/report/withReportOrNotFound.tsx

Line 107 in 7748eff

return withOnyx<TProps & RefAttributes<TRef>, WithReportOrNotFoundOnyxProps>({

What alternative solutions did you explore? (Optional)