[HOLD for payment 2024-10-16] [$250] Expensify Card - On report fraud page, error does not redirect and can not be closed

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.32-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

PreCond: User has Expensify Card set up and assigned

1. Open the New Expensify iOS app
2. Sign into a valid account
3. Go to Profile > Wallet > Expensify Card
4. Go to Report Virtual Card fraud > Deactivate Card

Expected Result:

User expects that after the loading spinner on the button, a redirect occurs

Actual Result:

No redirect occurs after hitting the button, the button can be hit several times. Only after exiting the page and going back will the user notice an error message. This error message can not be deleted by tapping the "X" button.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6600158_1726074112762.Error_message_can_not_be_dismissed_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834534968013390587
• Upwork Job ID: 1834534968013390587
• Last Price Increase: 2024-09-13
• Automatic offers:
• dominictb | Contributor | 103979604

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Card fraud report page does not redirect back upon clicking Deactivate Card and error message could not be dismissed.

What is the root cause of that problem?

• We haven't set navigation flow on clicking Deactivate Card button.
• Error message is hard coded to not allow user to dismiss.

What changes do you think we should make in order to solve the problem?

• For redirecting based on whether we want to redirect to wallet or card page add....

// redirect to wallet page
Navigation.navigate(ROUTES.SETTINGS_WALLET.getRoute());

or

// redirect to card page
Navigation.navigate(ROUTES.SETTINGS_WALLET_DOMAINCARD.getRoute(cardID));

here

App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

Line 75 in ecb629d

onSubmit={() => Card.reportVirtualExpensifyCardFraud(virtualCard.cardID)}

• And for dismissing error revert canDismissError to true here
  

  App/src/pages/settings/Wallet/PaymentMethodList.tsx

  Line 220 in ecb629d

  canDismissError: false,

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• No redirect occurs after hitting the button, the button can be hit several times.
• Only after exiting the page and going back will the user notice an error message. This error message can not be deleted by tapping the "X" button.

What is the root cause of that problem?

Issue 1: No redirect occurs after hitting the button, the button can be hit several times.

• In ReportVirtualCardFraudPage we use cardList?.[cardID].errors to check whether the form encountered any error or not.

• In case of the bug, after clicking on the "Deactivate card" button, there is an error returned by BE, leads to the condition:
  

  App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

  Line 54 in ecb629d

  if (!isEmptyObject(virtualCard?.errors)) {

  
  is true, hence the redirect logic:
  

  App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

  Line 58 in ecb629d

  Navigation.navigate(ROUTES.SETTINGS_WALLET_DOMAINCARD.getRoute(cardID));

  
  is not called.

• However, no error message was displayed on that page. It is because, in the logic to get the error, we use:
  

  App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

  Line 46 in ecb629d

  const virtualCardError = ErrorUtils.getLatestErrorMessage(virtualCard?.errors ?? {});

  
  which will always be '', it should be const virtualCardError = ErrorUtils.getLatestErrorMessage(virtualCard),
  that leads to there is no error message displayed in:
  

  App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

  Line 76 in ecb629d

  message={virtualCardError}

issue 2: Only after exiting the page and going back will the user notice an error message. This error message can not be deleted by tapping the "X" button.

• When tapping on "Close" button, the error is not dismissed because of in the logic to clear the error:
  

  App/src/pages/settings/Wallet/PaymentMethodList.tsx

  Lines 130 to 151 in ecb629d

  	function dismissError(item: PaymentMethod) {
  	const isBankAccount = item.accountType === CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT;
  	const paymentList = isBankAccount ? ONYXKEYS.BANK_ACCOUNT_LIST : ONYXKEYS.FUND_LIST;
  	const paymentID = isBankAccount ? item.accountData?.bankAccountID ?? '' : item.accountData?.fundID ?? '';
  	if (!paymentID) {
  	Log.info('Unable to clear payment method error: ', undefined, item);
  	return;
  	}
  	if (item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
  	PaymentMethods.clearDeletePaymentMethodError(paymentList, paymentID);
  	if (!isBankAccount) {
  	PaymentMethods.clearDeletePaymentMethodError(ONYXKEYS.FUND_LIST, paymentID);
  	}
  	} else {
  	PaymentMethods.clearAddPaymentMethodError(paymentList, paymentID);
  	if (!isBankAccount) {
  	PaymentMethods.clearAddPaymentMethodError(ONYXKEYS.FUND_LIST, paymentID);
  	}
  	}
  	}

  
  we don't have a logic to handle the virtual card.

What changes do you think we should make in order to solve the problem?

Issue 1: No redirect occurs after hitting the button, the button can be hit several times.

• As mentioned above, we just need to update:
  

  App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

  Line 46 in ecb629d

  const virtualCardError = ErrorUtils.getLatestErrorMessage(virtualCard?.errors ?? {});

  
  to:

       const virtualCardError = ErrorUtils.getLatestErrorMessage(virtualCard)

Issue 2: Only after exiting the page and going back will the user notice an error message. This error message can not be deleted by tapping the "X" button.

1. Option 1:

• We can hide the "Close" button beside the error like we did in here:
  

  App/src/pages/settings/Wallet/PaymentMethodList.tsx

  Line 220 in ecb629d

  canDismissError: false,

• So we just need to update:
  

  App/src/pages/settings/Wallet/PaymentMethodList.tsx

  Line 253 in ecb629d

  canDismissError: true,

  
  to:

       canDismissError: false,

2. Option 2:

• We can add an additional logic to handle virtual card cases in dismissError function:

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Line 130 in ecb629d

function dismissError(item: PaymentMethod) {

    if (item.cardID) {
        Onyx.merge(`cardList`, {
            [item.cardID]: {
                errors: null,
            },
        });
        return;
    }

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834534968013390587

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[QasimBham]

Proposal
Please re-state the problem that we are trying to solve in this issue.
No redirect occurs after hitting the button, the button can be hit several times.
Only after exiting the page and going back will the user notice an error message. This error message can not be deleted by tapping the "X" button.
Solution:
we can redirect it to the specific user's card itself such that
Navigation.navigate(ROUTES.SETTINGS_WALLET_DOMAINCARD.getRoute(cardID));

[github-actions]

@user Your proposal will be dismissed because you did not follow the proposal template.