[$250] [HOLD for payment 2024-10-10] Categories - Spend category field is not grayed out after changing category offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-4
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #48391
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click Settings.
4. Go offline.
5. Click on any spend categories.
6. Change the category.

Expected Result:

The spend category field will be grayed out after changing category offline.

Actual Result:

The spend category field is not grayed out after changing category offline.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6594735_1725578843379.20240906_072521.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844768877300090073
• Upwork Job ID: 1844768877300090073
• Last Price Increase: 2024-10-11

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Spend category field is not grayed out after changing category offline

What is the root cause of that problem?

We don't handle the update pendingAction yet, here

What changes do you think we should make in order to solve the problem?

set the pendingAction update on optimistic data and revert back on failure data and on success data here

const optimisticData: OnyxUpdate[] = mccGroup
        ? [
              {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `policy_${policyID}`,
                value: {
                    mccGroup: {
                        [groupID]: {
                            category,
                            groupID,
                            pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                        },
                    },
                },
              },
          ]
        : [];

    const failureData: OnyxUpdate[] = mccGroup
        ? [
              {
                  onyxMethod: Onyx.METHOD.MERGE,
                  key: `policy_${policyID}`,
                  value: {
                    mccGroup: {
                        [groupID]: {
                            pendingAction: null,
                        },
                    },
                  },
              },
          ]
        : [];
    
    const successData: OnyxUpdate[] = mccGroup
        ? [
              {
                  onyxMethod: Onyx.METHOD.MERGE,
                  key: `policy_${policyID}`,
                  value: {
                    mccGroup: {
                        [groupID]: {
                            pendingAction: null,
                        },
                    },
                  },
              },
          ]
        : [];

Add pendingAction here

data: Object.entries(currentPolicy.mccGroup).map(
        ([mccKey, mccGroup]) =>
            ({
                categoryID: mccGroup.category,
                keyForList: mccKey,
                groupID: mccKey,
                policyID,
                tabIndex: -1,
                pendingAction: mccGroup.pendingAction
            } as ListItem),
    ),

And pass pendingAction here to greyed out the item

        <BaseListItem
            item={item}
            wrapperStyle={[isFocused && styles.sidebarLinkActive]}
            pressableStyle={[styles.mt2]}
            onSelectRow={onSelect}
            isFocused={isFocused}
            showTooltip
            keyForList={item.keyForList}
            pendingAction={item.pendingAction}
        >

RESULT

What alternative solutions did you explore? (Optional)

[miljakljajic]

I don't think this is a blocker - @iwiznia and also @roryabraham you're on deploy duty, what do you think?

[iwiznia]

I think it is, given it comes from the regression testing and it is happening on staging but not prod

[iwiznia]

Hmmmm weird, isn't this a new feature?