Missing create options from the DM create menu in some DMs and not others

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724860697269619

Action Performed:

1. Go to staging.new.expensify.com
2. Initiate a DM with people on expensify.com
3. Click the +

Expected Result:

All create menu options displayed (Split, Submit, Pay, Assign task and add)

Actual Result:

Only Assign task and add attachment options displayed for people on expensify.com

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[neonbhai]

Can reproduce:

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing create options from the DM create menu in some DMs and not others

What is the root cause of that problem?

This happened after #47214

We use isExpensifyTeam here to check if we should show the money request options. This function includes the check for @expensify domain, hence the options are not shown.

App/src/libs/ReportUtils.ts

Lines 6385 to 6387 in e054a71

	const otherParticipants = reportParticipants.filter(
	(accountID) => currentUserPersonalDetails?.accountID !== accountID && !PolicyUtils.isExpensifyTeam(allPersonalDetails?.[accountID]?.login),
	);

What changes do you think we should make in order to solve the problem?

We don't want to show the Create Options for only the Expensify guide emails (team.expensify.com). We'll create a uti isExpensifyGuide to help us

function isExpensifyGuide(email: string | undefined): boolean {
    const emailDomain = Str.extractEmailDomain(email ?? '');
    return emailDomain === CONST.EMAIL.GUIDES_DOMAIN;
}

Change here to:

const otherParticipants = reportParticipants.filter(
    (accountID) => currentUserPersonalDetails?.accountID !== accountID && !PolicyUtils.isExpensifyGuide(allPersonalDetails?.[accountID]?.login),
);

[trjExpensify]

That's not great, I've commented in the parent issue of the PR that introduced it as it's within the regression period: #46739

[twisterdotcom]

This was reverted, so, going to close this one.