Account switcher - Unable to select account via keyboard

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in as copilot.
3. Go to Account settings.
4. Click on the account switcher.
5. Select another account using keyboard.

Expected Result:

User should be able to select account via keyboard.

Actual Result:

Left hand pane scrolls down when trying to select account via keyboard.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6585856_1724883410357.20240829_061204.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dominictb]

Edited by proposal-police: This proposal was edited at 2024-08-29 10:50:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Left hand pane scrolls down when trying to select account via keyboard.

What is the root cause of that problem?

We're using Popover to render the account list

App/src/components/AccountSwitcher.tsx

Line 169 in 8c69c58

<Popover

and in this component we don't have the logic to focus on the popover so when users press up/down button, the below component will be scrolled

What changes do you think we should make in order to solve the problem?

We should use PopoverMenu instead of Popover

1. Update anchorPosition to horizontal and vertical
2. Add header text delegate.switchAccount like here
3. Update menuItems function to return PopoverMenuItem
4. Add menuItems={menuItems}

We should check other places that use Popover.

What alternative solutions did you explore? (Optional)

We can implement the logic to focus and press key in Popover same as PopoverMenu