[$250] Web- Search - Central pane is Search while LHN is inbox after clicking back button on card RHP

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.25-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com/search/filters/card
2. Click on the RHP back button.

Expected Result:

Central pane will remain as chat report.

Actual Result:

Central pane changes to Search, while LHN remain as Inbox.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6583887_1724736483068.20240827_132316.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0116f769d438f95ddb
• Upwork Job ID: 1829370703781172325
• Last Price Increase: 2024-08-30
• Automatic offers:
• jjcoffee | Reviewer | 103755576
• Nodebrute | Contributor | 103755578

Issue Owner

Current Issue Owner: @jjcoffee

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-08-27 11:35:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Central pane is Search while LHN is inbox after clicking back button on card RHP

What is the root cause of that problem?

When navigating to links such as https://dev.new.expensify.com:8082/search/filters/merchant, the background correctly shows the search central pane and search side bar. However, this consistency is not observed on the card link (https://dev.new.expensify.com:8082/search/filters/card).
We are not adding SCREENS.SEARCH.ADVANCED_FILTERS_CARD_RHP in

App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

Line 44 in 9ddca5c

[SCREENS.SEARCH.CENTRAL_PANE]: [

What changes do you think we should make in order to solve the problem?

We should add SCREENS.SEARCH.ADVANCED_FILTERS_CARD_RHP here for consistent behaviour.

    [SCREENS.SEARCH.CENTRAL_PANE]: [
        SCREENS.SEARCH.REPORT_RHP,
        SCREENS.SEARCH.TRANSACTION_HOLD_REASON_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_CURRENCY_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_DATE_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_DESCRIPTION_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_MERCHANT_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_REPORT_ID_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_AMOUNT_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_CATEGORY_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_KEYWORD_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_TAX_RATE_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_EXPENSE_TYPE_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_TAG_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_FROM_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_TO_RHP,
        SCREENS.SEARCH.ADVANCED_FILTERS_CARD_RHP
    ],

We should also investigate other areas where this error might be occurring.

What alternative solutions did you explore? (Optional)

[VictoriaExpensify]

I agree this is an issue that we should solve. I think wave_control is the best place for it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0116f769d438f95ddb