[$250] RBR shows in NewDot on connections that are only configurable in OldDot

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724202135633669

Action Performed:

1. On OldDot, go to Settings -> Workspaces
2. Choose a Control or Collect Workspace
3. Go to Connections -> QuickBooks Desktop -> Click Connect to QuickBooks Desktop
4. Click Shared Company Drive as an option and close the modal once it's giving you next steps.
5. Refresh the page and see the error "The connection could not be completed" appear
6. Open NewDot and see a RBR on your profile photo in the bottom navigation bar
7. Tap on Profile photo in the navbar -> Workspaces -> Same workspace as above -> Accounting
8. See an empty list with nothing to indicate the RBR error

Expected Result:

Expecting to either not see RBR or a note that this was configured in OldDot

Actual Result:

See an empty list with nothing to indicate the RBR error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa5ae4b74b2af547
• Upwork Job ID: 1828156369928229332
• Last Price Increase: 2024-09-02

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Edited by proposal-police: This proposal was edited at 2023-10-03T22:20:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

See an empty list with nothing to indicate the RBR error

What is the root cause of that problem?

• We don't display the quickbooksDesktop in policy accounting page.

What changes do you think we should make in order to solve the problem?

• In this page, introduce a new variable hasConnectedIntegrationNotSupportInND to check whether there is a connected integration which is not support in ND:

    const hasSyncError = PolicyUtils.hasSyncError(policy);
    const allAccoutingIntegrations = [...accountingIntegrations, 'quickbooksDesktop'];
    const connectedIntegration = getConnectedIntegration(policy, accountingIntegrations) ?? connectionSyncProgress?.connectionName;
    const allConnectedIntegration = getConnectedIntegration(policy, allAccoutingIntegrations) ?? connectionSyncProgress?.connectionName;
    const hasConnectedIntegrationNotSupportInND = !connectedIntegration && allConnectedIntegration;

• Update:
  

  App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

  Line 348 in f58439c

  if (isEmptyObject(policy?.connections) && !isSyncInProgress) {

        if (isEmptyObject(policy?.connections) && !isSyncInProgress && !(hasConnectedIntegrationNotSupportInND && hasSyncError)) {

so if we have an integration that is only supported in OD and encounter an error, we still return 4 integration options in other sections.

• Update:
  

  App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

  Line 428 in f58439c

  {connectionsMenuItems.map((menuItem) => (

                            {!(hasConnectedIntegrationNotSupportInND && hasSyncError) &&
                                connectionsMenuItems.map((menuItem) => (

• Update:
  

  App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

  Line 441 in f58439c

  {otherIntegrationsItems && (

                            {(otherIntegrationsItems || (hasConnectedIntegrationNotSupportInND && hasSyncError)) && (

• And finally, add an additional component to this:
  

  App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

  Line 440 in f58439c

  ))}

                            {hasConnectedIntegrationNotSupportInND && hasSyncError && (
                                <FormHelpMessage
                                    isError
                                    shouldShowRedDotIndicator
                                    message={
                                        <Text style={[{color: theme.textError}]}>
                                            There's an error with a connection that's been set up in Expensify Classic.
                                            <TextLink
                                                onPress={() => {
                                                    // Go to Expensify Classic.
                                                }}
                                            >
                                                {' Go to Expensiy Classic to fix this issue.'}
                                            </TextLink>
                                        </Text>
                                    }
                                    style={styles.menuItemError}
                                />
                            )}

Result:

What alternative solutions did you explore? (Optional)

• In this page, create:

    const hasSyncError = PolicyUtils.hasSyncError(policy);
    const allAccoutingIntegrations = [...accountingIntegrations, 'quickbooksDesktop'];
    const connectedIntegration = getConnectedIntegration(policy, accountingIntegrations) ?? connectionSyncProgress?.connectionName;
    const allConnectedIntegration = getConnectedIntegration(policy, allAccoutingIntegrations) ?? connectionSyncProgress?.connectionName;
    const hasConnectedIntegrationNotSupportInND = !connectedIntegration && allConnectedIntegration;

• Then update:
  

  App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

  Line 232 in ad7c1d5

  return [];

            if (hasConnectedIntegrationNotSupportInND) {
                return [
                    {
                        title: 'Other integration',
                        errorText: hasSyncError ? 'There was an error' : '',
                        shouldShowRightComponent: true,
                        rightComponent: (
                            <Button
                                onPress={() => {}}
                                text={'Redirect to OD'}
                                style={styles.justifyContentCenter}
                                small
                                isDisabled={isOffline}
                            />
                        ),
                        errorTextStyle: [styles.mt5],
                        shouldShowRedDotIndicator: true,
                        interactive: false,
                        wrapperStyle: [styles.sectionMenuItemTopDescription, hasSyncError && styles.pb0],
                    },
                ];
            }
            return [];

• Optionally, we can update:
  

  App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

  Line 366 in ad7c1d5

  integrationToDisconnect: connectedIntegration,

  
  to:

                                integrationToDisconnect: allConnectedIntegration

• It is a demo code, the detail can be improved later.

What alternative solutions did you explore? (Optional)

• If we want to hide the RBR, update:
  

  App/src/libs/PolicyUtils.ts

  Lines 92 to 94 in ad7c1d5

  	function hasSyncError(policy: OnyxEntry<Policy>): boolean {
  	return (Object.keys(policy?.connections ?? {}) as ConnectionName[]).some((connection) => !!getSynchronizationErrorMessage(policy, connection, false));
  	}

  
  to:

function hasSyncError(policy: OnyxEntry<Policy>): boolean {
    const accountingIntegrations = Object.values(CONST.POLICY.CONNECTIONS.NAME);
    return (Object.keys(policy?.connections ?? {}) as ConnectionName[]).some((connection) => !!getSynchronizationErrorMessage(policy, connection, false) && accountingIntegrations.includes(connection) );
}

• Then do the same in the main solution to indicate that there is another connection that is only supported in OD.

[daledah]

Proposal updated

[dubielzyk-expensify]

So for the solution here we want to show an error for integrations that aren't configurable via NewDot:

We don't want to hide the RBR or change anything about any other screen than the one above. Simple say that the integration error needs to be fixed in Expensify Classic. If this error is about the integrations that we support in NewDot, then we don't wanna do anything.

Hope that clarifies it 😄

[daledah]

Proposal updated

[melvin-bot]

@OfstadC Huh... This is 4 days overdue. Who can take care of this?