[HOLD for payment 2024-10-17] [$250] Next Steps - "Waiting for userAdmin to finish setting up a business bank account" is not displayed with the correct conditions

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Reproducible in staging?: Yes
Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/417883 - Being added here

Email or phone of affected tester (no customers): applausetester+ig8@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause - Internal team

Action Performed:

Preconditions:

• Workspace approval & payments are enabled
• Bank account setup has a "Unfinished" setup and bank account is pending validation.
• Employee has submitted a report > the report is approved and is "awaiting payment"

1. Navigate to the workspace chat
2. Click on the report that is awaiting payment
3. Check the next steps banner

Expected Result:

The next steps banner indicates "Waiting for userAdmin to finish setting up a business bank account" when a report is pending payment and the admin has not finished setting up the business bank account in the workspace.

Actual Result:

"Waiting for [userAdmin] to pay expense(s)." is displayed.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018c20eb05dc94ed77
• Upwork Job ID: 1823304297972705293
• Last Price Increase: 2024-08-13

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Current assignee @dylanexpensify is eligible for the Bug assigner, not assigning anyone new.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Waiting for userAdmin to finish setting up a business bank account" is not displayed with the correct conditions

What is the root cause of that problem?

Currently, we don't have any logic to determine if the owner is setting up a bank account. We simply display the following message: Waiting for [userAdmin] to pay expense(s).

App/src/libs/NextStepUtils.ts

Lines 253 to 274 in 4b30725

	optimisticNextStep = {
	type,
	icon: CONST.NEXT_STEP.ICONS.HOURGLASS,
	message: [
	{
	text: 'Waiting for ',
	},
	{
	text: reimburserDisplayName,
	type: 'strong',
	},
	{
	text: ' to ',
	},
	{
	text: 'pay',
	},
	{
	text: ' %expenses.',
	},
	],
	};

What changes do you think we should make in order to solve the problem?

Add another check in following case to show this message "Waiting for userAdmin to finish setting up a business bank account"

App/src/libs/NextStepUtils.ts

Line 230 in 4b30725

case CONST.REPORT.STATUS_NUM.APPROVED:

We can use the check reimbursementAccount?.achData?.state === 'SETUP' to determine if the admin is in the process of setting up the bank account. Based on this check, we can then display the appropriate message of our choice.
(Pseudocode)

   if(reimbursementAccount?.achData?.state === 'SETUP'){
                optimisticNextStep = {
                    type,
                    icon: icon of our choice,
                    message: [
                        {
                            text: 'Waiting for ',
                        },
                        {
                            text: reimburserDisplayName,
                            type: 'strong',
                        },
............

We can select the appropriate state based on when we want the message to appear.

What alternative solutions did you explore? (Optional)

[dylanexpensify]

Reviewing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018c20eb05dc94ed77

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

We can use the check reimbursementAccount?.achData?.state === 'SETUP'

When the account adding process has not been started, there is no field of achData in reimbursementAccount. Could you clarify all the conditions in which we will show this message of Waiting for userAdmin to finish setting up a business bank account.

[dylanexpensify]

@c3024 sure! We will only show this when an admin payee has payments enabled, report needing to be reimbursed, and their bank account needing to be verified.