[C+ Checklist Needs Completion] [$250] Search-Expenses tab does not update to show all expenses after deleting the filtered workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.19-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account has some expenses

1. Go to staging.new.expensify.com
2. Create a new workspace
3. Go to Search
4. Open workspace switcher
5. Select the workspace created in Step 2
6. Go to Account settings > Workspaces
7. Click 3-dot menu next to workspace > Delete
8. Delete the workspace
9. Go to Search

Expected Result:

After the workspace is deleted, the workspace switcher will reset to "Expensify" and the expenses list will show all the expenses under "Expensify"

Actual Result:

The workspace switcher seems to reset to "Expensify", but the expenses list does not update to show all the expenses under "Expensify". When opening the workspace switcher, "Expensify" is actually not selected (not checked)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6570285_1723492104646.20240813_034217.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cc0c01ced1c31ec0
• Upwork Job ID: 1823121762787920792
• Last Price Increase: 2024-08-12
• Automatic offers:
• alitoshmatov | Reviewer | 103499624
• nkdengineer | Contributor | 103499625
• allgandalf | Contributor | 103499695

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace switcher seems to reset to "Expensify", but the expenses list does not update to show all the expenses under "Expensify". When opening the workspace switcher, "Expensify" is actually not selected (not checked)

What is the root cause of that problem?

Now when we delete the Workspace and return to the search page by clicking on the search icon, we are not deleting the Workspace's policyIDs (which have been deleted) in the route in here

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 89 to 95 in 598a683

	interceptAnonymousUser(() => {
	const currentSearchParams = getCurrentSearchParams();
	if (currentSearchParams) {
	const {q, ...rest} = currentSearchParams;
	Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: q, ...rest}));
	return;
	}

What changes do you think we should make in order to solve the problem?

We should check if the policyIDs in currentSearchParams still exist. If it no longer exists, we will remove it from the route. in here.

 const policy = PolicyUtils.getPolicy(currentSearchParams?.policyIDs);
 Navigation.navigate(
     ROUTES.SEARCH_CENTRAL_PANE.getRoute({
     query: q,
     isCustomQuery: currentSearchParams.isCustomQuery,
     policyIDs: policy ? currentSearchParams?.policyIDs : undefined
     }),
);

What alternative solutions did you explore? (Optional)

NA

[marcochavezf]

Thanks @nkdengineer, the proposal sounds good, the only thing that causes me noise is that we pass policyIDs (plural) as policyID (singular), but I noticed this has been used interchangeably in other parts of the code as route parameter.

I will prepare a quick PR since I already have the change locally, but I will assign you for the payment

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cc0c01ced1c31ec0