[$250] Distance - App crashes when deleting a distance expense when there are two distance expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: .0.17-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sarahhailu1268+dhsdfsdhgshg@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to the staging app with a new account
2. Create a new workspace
3. Go to FAB > Submit Expense > Distance
4. Enter start and finish waypoints > Submit it to the workspace
5. Again go to FAB > Submit Expense > Distance
6. Enter start and finish waypoints > Submit it to the workspace
7. After the expenses are created go into the combined report and click on the first expense
8. Click on the header > Delete expense > Confirm

Expected Result:

The app will not crash and the expense is successfully deleted

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6564505_1723039542006.2024-08-07_16_51_46.mp4

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183948967c6155377
• Upwork Job ID: 1821209382283102288
• Last Price Increase: 2024-08-14
• Automatic offers:
• dominictb | Contributor | 103641053

Issue Owner

Current Issue Owner: @dominictb

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0183948967c6155377

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-08-07 15:46:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when deleting a distance expense when there are two distance expenses

What is the root cause of that problem?

When deleting a distance request tags become undefined here

App/src/libs/OptionsListUtils.ts

Lines 1355 to 1356 in 0a33186

	function hasEnabledTags(policyTagList: Array<PolicyTagList[keyof PolicyTagList]>) {
	const policyTagValueList = policyTagList.map(({tags}) => Object.values(tags)).flat();

What changes do you think we should make in order to solve the problem?

We should use nullish coalescing operator to return empty array when tags is undefined in Ojbect.values

const policyTagValueList = policyTagList.map(({tags}) => Object.values(tags ?? [])).flat();

What alternative solutions did you explore? (Optional)

Result:

Screen.Recording.2024-08-07.at.7.00.55.in.the.evening.mp4

[etCoderDysto]

Updated Proposal

• Added video result