[Paid] [$250] Selecting yourself as the assignee should default Share somewhere to your self-DM

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @srikarparsi
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722970867440899

Action Performed:

1. Click FAB
2. Click Assign Task
3. Enter in a title and click next
4. Select yourself as the assignee

Expected Result:

Your self DM should be selected under Share somewhere

Actual Result:

Nothing happens to Share somewhere

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.422.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ee964f440e728109
• Upwork Job ID: 1820902098430288377
• Last Price Increase: 2024-08-06
• Automatic offers:
• nkdengineer | Contributor | 103489021

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ee964f440e728109

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selecting yourself as the assignee should default Share somewhere to your self-DM

What is the root cause of that problem?

skipShareDestination is passes as true to setAssigneeValue.

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Line 195 in 0700854

OptionsListUtils.isCurrentUser({...option, accountID: option?.accountID ?? -1, login: option?.login ?? ''}),

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Line 209 in 0700854

OptionsListUtils.isCurrentUser({...option, accountID: option?.accountID ?? -1, login: option?.login ?? undefined}),

What changes do you think we should make in order to solve the problem?

Remove the last param when creating new task or for both. We can also remove skipShareDestination param from setAssigneeValue.

What alternative solutions did you explore? (Optional)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens to Share somewhere

What is the root cause of that problem?

We only set the share destination if the selection assignee is not the current user here.

App/src/libs/actions/Task.ts

Line 777 in fb0043a

if (!isCurrentUser) {

App/src/libs/actions/Task.ts

Line 798 in fb0043a

if (!shareToReportID && !skipShareDestination) {

What changes do you think we should make in order to solve the problem?

If the selected assignee is the current user, we should add the share somewhere as the self-chat. We can add a else condition for this case like this.

OPTIONAL: We can also call setAssigneeChatReport inside the case the current user is the assignee. If we want to do that, we can move the logic set assign chat report and share somewhere to outside the if condition here and add a else condition to assign the report as the selfDM.

else {
    const selfDMReportID = ReportUtils.findSelfDMReportID();
    // If there is no share destination set, automatically set it to the assignee chat report
    // This allows for a much quicker process when creating a new task and is likely the desired share destination most times
    if (!shareToReportID && !skipShareDestination) {
        setShareDestinationValue(selfDMReportID ?? '-1');
    }
}

App/src/libs/actions/Task.ts

Line 777 in fb0043a

if (!isCurrentUser) {

What alternative solutions did you explore? (Optional)

[kpadmanabhan]

I was trying to reproduce the issue. However it works as expected as in test steps in staging.new.expensify.com
@m-natarajan : am i missing any steps? isnt this what the expected behaviour is?

Screen.Recording.2024-08-07.021047.mp4

[srikarparsi]

Hi @kpadmanabhan, the expected behavior is if you select yourself in the Assignee field, then your self DM should automatically populate in the Share somewhere field.