Distance-"Rate" field is not displayed in request details page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #40021

Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): sarahhailu45+higjht@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Pre-requisite:
Sign in with a new Gmail account
Have a collect workspace with distance rates enabled and multiple Distance Rates
Steps

1. Click on FAB > Submit Expense > Distance
2. Choose waypoints > Choose the collect workspace > Submit
3. Navigate to the request details page

Expected Result:

The "Rate" field is displayed and can be changed

Actual Result:

The "Rate" field is not displayed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6563036_1722921063488.2024-08-06_08_00_22.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance-"Rate" field is not displayed in request details page

What is the root cause of that problem?

Rate field is disabled when canUseP2PDistanceRequests is false.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 334 to 372 in 963f8ce

	const distanceRequestFields = canUseP2PDistanceRequests ? (
	<>
	<OfflineWithFeedback pendingAction={getPendingFieldAction('waypoints')}>
	<MenuItemWithTopDescription
	description={translate('common.distance')}
	title={distanceToDisplay}
	interactive={canEditDistance && !readonly}
	shouldShowRightIcon={canEditDistance && !readonly}
	titleStyle={styles.flex1}
	onPress={() =>
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DISTANCE.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '-1', report?.reportID ?? '-1'))
	}
	/>
	</OfflineWithFeedback>
	<OfflineWithFeedback pendingAction={getPendingFieldAction('customUnitRateID')}>
	<MenuItemWithTopDescription
	description={translate('common.rate')}
	title={rateToDisplay}
	interactive={canEditDistanceRate}
	shouldShowRightIcon={canEditDistanceRate}
	titleStyle={styles.flex1}
	onPress={() =>
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DISTANCE_RATE.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '-1', report?.reportID ?? '-1'))
	}
	/>
	</OfflineWithFeedback>
	</>
	) : (
	<OfflineWithFeedback pendingAction={getPendingFieldAction('waypoints')}>
	<MenuItemWithTopDescription
	description={translate('common.distance')}
	title={transactionMerchant}
	interactive={canEditDistance && !readonly}
	shouldShowRightIcon={canEditDistance && !readonly}
	titleStyle={styles.flex1}
	onPress={() => Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DISTANCE.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '-1', report?.reportID ?? '-1'))}
	/>
	</OfflineWithFeedback>
	);

What changes do you think we should make in order to solve the problem?

We should remove the condition and always show the rate field but we will make it non editable using interactive prop when canUseP2PDistanceRequests is false.

What alternative solutions did you explore? (Optional)

[neil-marcellini]

This is not a problem, it's how the p2p distance beta works. We hide all features related to p2p distance, such as the rate field.

Also @m-natarajan why did you say it's not reproducible on production? The rate field is appropriately hidden there as well.