[HOLD for payment 2024-08-29] [$250] NetSuite - Sync error isn't displayed when connecting to NetSuite with invalid credentials

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4807616&group_by=cases:section_id&group_id=314239&group_order=asc
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the app
2. Log in with a new Gmail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to NetSuite with invalid credentials

Expected Result:

Sync error should be displayed

Actual Result:

Sync error isn't displayed when connecting to NetSuite with invalid credentials

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6561075_1722694354704.JLKK3142.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ceab16370193c3b8
• Upwork Job ID: 1820591512049375650
• Last Price Increase: 2024-08-05

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sync error isn't displayed when connecting to NetSuite with invalid credentials

What is the root cause of that problem?

We don't return true on hasSynchronizationError function if the net suite connection verified value is false, since verified is an indicator of whether the sync connection has been successful

App/src/libs/actions/connections/index.ts

Lines 366 to 372 in d0ecede

	function hasSynchronizationError(policy: OnyxEntry<Policy>, connectionName: PolicyConnectionName, isSyncInProgress: boolean): boolean {
	// NetSuite does not use the conventional lastSync object, so we need to check for lastErrorSyncDate
	if (connectionName === CONST.POLICY.CONNECTIONS.NAME.NETSUITE) {
	return !isSyncInProgress && !!policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE].lastErrorSyncDate;
	}
	return !isSyncInProgress && policy?.connections?.[connectionName]?.lastSync?.isSuccessful === false;
	}

App/src/types/onyx/Policy.ts

Lines 971 to 972 in d0ecede

	/** Whether the sync connection has been successful */
	verified: boolean;

What changes do you think we should make in order to solve the problem?

Update this code to the following to return true if the net suite connection verified value is false

    if (connectionName === CONST.POLICY.CONNECTIONS.NAME.NETSUITE) {
        return !isSyncInProgress && (!!policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE].lastErrorSyncDate || !policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified);
    }

RESULT

New-Expensify.26.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ceab16370193c3b8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[sakluger]

Tagging @yuwenmemon, @mananjadhav, @shubham1206agra since you all worked on the design doc for this feature.

[shubham1206agra]

@sakluger This looks like a BE issue.