[Search v1.2] - Unsubmitted expense can be held without error in Search

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
**Reproducible in production?:*Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4804456
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Delayed submission is enabled on Workflows
• Workspace has an approver (admin)

1. Go to staging.new.expensify.com
2. [Employee] Go to workspace chat
3. [Employee] Create two expenses and do not click Submit button
4. [Admin] Go to transaction thread of any submitted expense from employee
5. [Admin] Click on the report header > Hold
6. [Admin] Enter reason and save it
7. [Admin] Note that it shows "This request is being modified by another member." and the expense cannot be held
8. [Admin] Go to Search
9. [Admin] Select the expense from Step 4 via checkbox
10. [Admin] Click on the dropdown > Hold
11. [Admin] Enter reason and save it
12. [Admin] Note that admin can hold the request from Search and there is no error message

Expected Result:

Admin should be prevented from holding expenses that are not submitted yet in Search

Actual Result:

In Step 7, admin is not allowed to hold unsubmitted expense when holding via transaction thread
In Step 12, admin can hold unsubmitted expense via dropdown button in Search

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6560305_1722614731549.20240802_235819.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[FitseTLT]

BE

[melvin-bot]

@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

@cdOut is your PR going to take care of this, actually?

[cdOut]

@trjExpensify Hm, looking at the video it looks a little sketchy, it might be using different logic there. I can test it on the hold cleanup PR and if it doesn't fix it I can work on this one after.

[trjExpensify]

Okay, sounds good. Let me know!

[trjExpensify]

Any luck with testing that @cdOut?