[PAID] [Search v2.1] - Sorting on Drafts and Finished does not work at all

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+khcategory15@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account has lots of expenses in Drafts and Finished section (Search)

1. Go to staging.new.expensify.com
2. Go to Search
3. Go to Drafts
4. Apply Date, Merchant and Amount sorting
5. Repeat Step 3 and 4 with Finished section

Expected Result:

The expenses will be sorted accordingly

Actual Result:

The sorting on Drafts and Finished does not work at all

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6559944_1722577006437.20240802_133409.mp4

Bug6559944_1722594720567.bandicam_2024-08-02_18-30-56-057.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dangrous]

Seems to happen on production build on local, so maybe backend or a previous regression that wasn't caught. Asking the folks working on search to have a look

[rayane-d]

I believe this issue is related to a backend bug. @luacmartins recently worked on a backend change (#46481 (comment)) to address this bug, which could be causing the current problem. However, @luacmartins is currently out of the office. Can we find someone internally to handle this?

[dangrous]

I'm continuing to look into it but haven't found a fix yet. @iwiznia it looks like you worked on some of the syntax - any ideas? I've confirmed that the asc/desc exists correctly as ORDER BY in the query that's run here (e.g. ORDER BY toUser asc LIMIT 51) but the data returned, at least by this point is no different, no matter the sort order that was sent. So, need to figure out why that's not changing anything...

The search already gets wacky results on prod, so although clicking the columns does CHANGE the sort, it's still wrong, so I'm not sure this is enough of an issue to block deploy... but open to other opinions

[dangrous]

Running SQL queries directly via command line DOES result in differently ordered results... so the issue has to be in Search::buildTransactionResponse()