[HOLD on #47369] [$250] Web - Onboarding - Onboarding video ignores mute and doesn't stop playing in background

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open staging.new.expensifail.com and create new gmail account
2. On Onboarding modal, select "something else" and enter any name
3. After selecting continue, QUICKLY tap on profile pic/account settings before "Welcome to Expensify" video opens
4. Observe to "Welcome to Expensify" video

Expected Result:

Onboarding video is played correctly and adheres to mute

Actual Result:

Video opens with sound playing even though mute is activated. Sound continues to play on repeat even though user has closed video

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6557413_1722350374316.e85873d8-cef9-4327-98d5-9f08bf133540.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012cf16a806465ece4
• Upwork Job ID: 1818615551381835090
• Last Price Increase: 2024-08-14

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[twisterdotcom]

My days, what a horrible bug. It's like it's set to max max volume by default. It's so tinny and loud.

46548.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012cf16a806465ece4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding - Onboarding video ignores mute and doesn't stop playing in background

What is the root cause of that problem?

We didn't pass the initial value to the Expo video for volume and isMuted, we only pass the value if we update the volume and invoke the updateVolume function

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Line 181 in 05e044a

updateVolume(status.isMuted ? 0 : status.volume || 1);

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines 344 to 370 in 05e044a

	<Video
	ref={videoPlayerRef}
	style={[styles.w100, styles.h100, videoPlayerStyle]}
	videoStyle={[styles.w100, styles.h100, videoStyle]}
	source={{
	// if video is loading and is offline, we want to change uri to "" to
	// reset the video player after connection is back
	uri: !isLoading || (isLoading && !isOffline) ? sourceURL : '',
	}}
	shouldPlay={shouldPlay}
	useNativeControls={false}
	resizeMode={resizeMode as ResizeMode}
	isLooping={isLooping}
	onReadyForDisplay={(e) => {
	if (isCurrentlyURLSet && !isUploading) {
	playVideo();
	}
	onVideoLoaded?.(e);
	const {source} = videoPopoverMenuPlayerRef.current?.props ?? {};
	if (typeof source === 'number' || !source || source.uri !== sourceURL) {
	return;
	}
	videoPlayerRef.current?.setStatusAsync?.({rate: currentPlaybackSpeed});
	}}
	onPlaybackStatusUpdate={handlePlaybackStatusUpdate}
	onFullscreenUpdate={handleFullscreenUpdate}
	/>

We do not listen to React navigation when the screen is blurred when we navigate to another screen, we do not pause the video

What changes do you think we should make in order to solve the problem?

We can pass volume and isMuted properties for the initial value to the Video expo element
And listen to React Navigation when the screen is blurred we can pause the Video element

Here's the code:

# Listen to React Navigation
useEffect(() => {
    const unsubscribe = navigation.addListener('blur', () => {
        pauseVideo()
    });

    return unsubscribe;
}, [navigation, pauseVideo]);

# Video Element
const {updateVolume, volume} = useVolumeContext();
<Video
    ref={videoPlayerRef}
    style={[styles.w100, styles.h100, videoPlayerStyle]}
    videoStyle={[styles.w100, styles.h100, videoStyle]}
    source={{
        // if video is loading and is offline, we want to change uri to "" to
        // reset the video player after connection is back
        uri: !isLoading || (isLoading && !isOffline) ? sourceURL : '',
    }}
    shouldPlay={shouldPlay}
    useNativeControls={false}
    resizeMode={resizeMode as ResizeMode}
    isLooping={isLooping}
    onReadyForDisplay={(e) => {
        if (isCurrentlyURLSet && !isUploading) {
            playVideo();
        }
        onVideoLoaded?.(e);
        const {source} = videoPopoverMenuPlayerRef.current?.props ?? {};
        if (typeof source === 'number' || !source || source.uri !== sourceURL) {
            return;
        }
        videoPlayerRef.current?.setStatusAsync?.({rate: currentPlaybackSpeed});
    }}
    onPlaybackStatusUpdate={handlePlaybackStatusUpdate}
    onFullscreenUpdate={handleFullscreenUpdate}
    volume={volume.value}
    isMuted={volume.value === 0}
/>

What alternative solutions did you explore? (Optional)

[NJ-2020]

Proposal updated

[NJ-2020]

@mkhutornyi Please kindly review above proposal