[$250] mWeb - Group - New users are not displayed in group name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): https://expensify.testrail.io/index.php?/tests/view/4784615
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Log in a new gmail account
3. Tap fab - start chat
4. Enter a new user with no expensify account and tap add to group
5. Tap group name.

Expected Result:

New users must be displayed in group name

Actual Result:

New users are not displayed in group name
Reproducible on these devises:
Samsung galaxy Ao2s/12 - Chrome.
Redmi note 10s/Android 13, Samsung Galaxy m2/Android 12

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556868_1722299822512.newv.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01511ab0ad63b9289d
• Upwork Job ID: 1818320616796150714
• Last Price Increase: 2024-07-30
• Automatic offers:
• hoangzinh | Reviewer | 103362702
• nkdengineer | Contributor | 103362703

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group - New users are not displayed in group name

What is the root cause of that problem?

In this case, we use ReportUtils.getGroupChatName function to get group name

App/src/pages/NewChatConfirmPage.tsx

Line 64 in 5d26dbe

const groupName = newGroupDraft?.reportName ? newGroupDraft?.reportName : ReportUtils.getGroupChatName(participantAccountIDs ?? []);

And in ReportUtils.getGroupChatName function, we use getDisplayNameForParticipant function

App/src/libs/ReportUtils.ts

Line 2017 in 6bc174f

.map((participant) => getDisplayNameForParticipant(participant, isMultipleParticipantReport))

The getDisplayNameForParticipant function return empty string, because the App can't find accountID of new user in personalDetail

What changes do you think we should make in order to solve the problem?

We need to add a fallback value when the App can't find accountID of new user in personalDetail. Keep in mind that the new user's email is stored in newGroupDraft.participants

In getGroupChatName function, we can replace participantAccountIDs param into participant param. This participant parameter will contain both the accountID and the login field, allowing us to use participant.login as a default value.

Additional, we maybe need to apply the same solution in here

App/src/pages/GroupChatNameEditPage.tsx

Line 50 in 5d26dbe

() => (report ? ReportUtils.getGroupChatName(undefined, false, report) : ReportUtils.getGroupChatName(draftParticipantAccountIDs)),

Result:

What alternative solutions did you explore? (Optional)

We can introduce new param in getDisplayNameForParticipant function called participant. And then if the App can't find accountID of new user in personalDetail, we will use participant.login as a default value

[cretadn22]

I have implemented my solution locally and included the results as evidence in my proposal

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01511ab0ad63b9289d