[$250] iOS - Onboarding task deeplinks used within the app redirect users to the web

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #46082

Action Performed:

1. Open the iOS app
2. Create a new account (please use a public domain)
3. In the onboarding modal, select "manage my team's expenses"
4. Go to Expensify chat to view the task checklist
5. Open a task that contains a deeplink (e.g., meet your setup specialist or set up categories)
6. Open the desired task and tap on the hyperlink present within the steps (e.g., #admins room if meeting your setup specialist, or Workspaces if setting up categories)

Expected Result:

Onboarding task deeplinks used within the app should redirect users to the correct screen within the app

Actual Result:

Onboarding task deeplinks used within the app redirect users to the web

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556810_1722294279029.QA-build-web-redirection-9.0.14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fe8e043da71e3915
• Upwork Job ID: 1818998994406051154
• Last Price Increase: 2024-08-22
• Automatic offers:
• nkdengineer | Contributor | 103652377

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding task deeplinks used within the app redirect users to the web

What is the root cause of that problem?

The links on onboarding tasks created here

App/src/libs/actions/Report.ts

Lines 3272 to 3273 in e81223b

	adminsRoomLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID ?? '-1')}`,
	workspaceLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,

So if onboarding completed in production the links become https://new.expensify.com/...
if onboarding completed in staging the links become https://staging.new.expensify.com/...

If onboarding completed in production and link opened in staging we will encounter this issue

What changes do you think we should make in order to solve the problem?

Remove hasSameOrigin has origin from this condition

App/src/libs/actions/Link.ts

Line 145 in e81223b

if (internalNewExpensifyPath && hasSameOrigin) {

if (internalNewExpensifyPath) {

What alternative solutions did you explore? (Optional)

[arosiclair]

I reproduced on staging and not on production. It seems like there might be something wrong with our staging ENV for iOS since the link is generated in NewDot and it is using the prod URL. I'll try reproducing on Android to verify.

[arosiclair]

Not reproducible on Android staging v9.0.14.-3. I'm almost certain there's something going on with our staging .env

[arosiclair]

In these logs you can see we're sending Meet your setup specialist... text as a param with the prod link.