[$250] Web - Email Mention Displays Number Instead of Email When Edited

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): betlihemasfaw14@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to self DM
2. Write an email with a mention (e.g., betelihemasfaw14@gmail.com
   ).
3. Use the up arrow to edit the message

Expected Result:

The email should be displayed when attempting to edit the mentioned email

Actual Result:

When trying to edit the mentioned email, a number with the mention is displayed instead of the email

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552541_1721904774758.Screen_Recording_2024-07-25_at_3.38.52_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015d8db50900d91088
• Upwork Job ID: 1818341999146391970
• Last Price Increase: 2024-07-30

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015d8db50900d91088

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[jp928]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When edit a mentioned user, the user name turns into account number.

What is the root cause of that problem?

In the following code

App/src/libs/Parser.ts

Line 18 in 881c548

accountIDToNameMap[personalDetails.accountID] = personalDetails.login ?? String(personalDetails.accountID);

the account id is saved into accountIDToNameMap

While editing a message, the parser in the following code

App/src/libs/Parser.ts

Line 34 in 881c548

accountIDToName: extras?.accountIDToName ?? accountIDToNameMap,

would use String(personalDetails.accountID) to parse the mentioned user.

What changes do you think we should make in order to solve the problem?

use accountIDToNameMap[personalDetails.accountID] = personalDetails.login ?? personalDetails.displayName;

What alternative solutions did you explore? (Optional)

Add login attribute in the payload of personalDetialsList

[DylanDylann]

This issue is fixed by this PR

@lschurr Let's close this issue