[PAID] [$250] Workspace -Workspace avatar turn to default when invited admin try to delete the workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a750@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. User A creates workspace with custom Avatar and invite User B as member
2. User A promotes User B as admin
3. As User B delete the workspace

Expected Result:

Workspace should remain custom avatar when admin tries to delete

Actual Result:

Workspace avatar turn to default when invited admin tries to delete the workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553993_1722019720158.Recording__3608.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0121268c92b5fca0cf
• Upwork Job ID: 1818882687051192738
• Last Price Increase: 2024-08-01

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace avatar turn to default when invited admin try to delete the workspace

What is the root cause of that problem?

We set avatarURL to empty string on deleteWorkspace optimisticData

App/src/libs/actions/Policy/Policy.ts

Line 252 in 9901ca3

avatarURL: '',

What changes do you think we should make in order to solve the problem?

Remove this code avatarURL: '', and don't set avatarURL to empty string on deleteWorkspace optimisticData

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS avatar turns to default when the admin try to delete the workspace but failed.

What is the root cause of that problem?

There are 2 issues here. When we delete the WS, we optimistically clear the avatar.

App/src/libs/actions/Policy/Policy.ts

Lines 247 to 252 in 9901ca3

	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	avatarURL: '',

But we never revert the avatar (or other data) when it fails.

Second, the delete action can only be performed by the owner, but we show the delete button for all admins.

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 86 in 9901ca3

const readOnly = !PolicyUtils.isPolicyAdmin(policy);

App/src/pages/workspace/WorkspaceProfilePage.tsx

Lines 264 to 280 in 9901ca3

	{!readOnly && (
	<View style={[styles.flexRow, styles.mt6, styles.mnw120]}>
	<Button
	accessibilityLabel={translate('common.share')}
	text={translate('common.share')}
	onPress={onPressShare}
	medium
	icon={Expensicons.QrCode}
	/>
	<Button
	accessibilityLabel={translate('common.delete')}
	text={translate('common.delete')}
	style={[styles.ml2]}
	onPress={() => setIsDeleteModalOpen(true)}
	medium
	icon={Expensicons.Trashcan}
	/>

What changes do you think we should make in order to solve the problem?

1. Add failureData to revert back the workspace avatar (and other data)
2. Show the delete button for owner only.

const isOwner = PolicyUtils.isPolicyOwner(policy, session.accountID);
{isOwner && // delete button}

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0121268c92b5fca0cf