[YAUHENI - CHECKLIST][$250] Chat - Chat not scrolled to bottom when returned from thread and send a message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4766826&group_by=cases:section_id&group_order=asc&group_id=306202
Email or phone of affected tester (no customers): applausetester+omqq1@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: user should be Signed In with applausetester+omqq1@applause.expensifail.com
account

1. Open app
2. Navigate to chat with applausetester+omqq3@applause.expensifail.com
3. Scroll up the chat
4. Navigate to any thread for any message in the chat
5. Click on the "From" link in header to navigate back to the main chat
6. Send any message

Expected Result:

Chat should be scrolled to the bottom when user send a message to the chat

Actual Result:

"New message" button displayed and chat remains on the same position

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553078_1721940541808.Screen_Recording_2024-07-25_at_23.36.21.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018faeb9106bd08688
• Upwork Job ID: 1817743200562670608
• Last Price Increase: 2024-07-29
• Automatic offers:
• ZhenjaHorbach | Reviewer | 103368524

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat doesn't scroll to bottom after coming back from thread using the parent link.

What is the root cause of that problem?

When we add the message, it will only scroll to the bottom if hasNewestReportActionRef is true.

App/src/pages/home/report/ReportActionsList.tsx

Lines 350 to 356 in 5e65276

	const scrollToBottomForCurrentUserAction = useCallback(
	(isFromCurrentUser: boolean) => {
	// If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
	// they are now in the list.
	if (!isFromCurrentUser || !hasNewestReportActionRef.current) {
	return;
	}

However, in our case, hasNewestReportActionRef is false. When we link to a message, the component will take the report actions only up to the current linked action + 50 actions (pagination size).

App/src/pages/home/report/ReportActionsView.tsx

Lines 255 to 256 in 5e65276

	const paginationSize = getInitialPaginationSize;
	return combinedReportActions.slice(Math.max(indexOfLinkedAction - paginationSize, 0));

So, if the message that we linked is very far above, then the scroll to bottom does nothing.

What changes do you think we should make in order to solve the problem?

We can use the same solution with scroll to bottom by clicking the "New message" here which removes the linked action param so all the report actions are loaded.

App/src/pages/home/report/ReportActionsList.tsx

Lines 415 to 423 in 5e65276

	const scrollToBottomAndMarkReportAsRead = () => {
	if (!hasNewestReportAction) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	Report.openReport(report.reportID);
	return;
	}
	reportScrollManager.scrollToBottom();
	readActionSkipped.current = false;
	Report.readNewestAction(report.reportID);

if (!hasNewestReportActionRef.current) {
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
}
InteractionManager.runAfterInteractions(() => reportScrollManager.scrollToBottom());

[jliexpensify]

Hi @bernhardoj - are you repro-ing this issue with your own account? If it's affecting 1 specific account, we probably don't need to fix it, but if it's affecting other accounts, we should.

I haven't been able to repro on my own test account.

[bernhardoj]

@jliexpensify yes, I can repro it. The issue doesn't depend on the account. To repro the issue, you need to link to the >= 52nd message (you can count it on the video too). For example, if you send 1,2,3,4,...100 to the chat, then you can copy the link of 40 and open it. This is due to pagination logic that only includes the current linked message + 50 messages below (40 + 50 = 90, 91-100 isn't included).

[jliexpensify]

Oh interesting, thanks for that info!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018faeb9106bd08688

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

@bernhardoj
Thanks for your proposal
Your proposal makes sense to me and also fixes the issue !

🎀👀🎀 C+ reviewed