[$250] iOS - Attachment - App crashes when editing comment with video

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.11-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to DM
3. Type any message (do not send it)
4. Tap + > Add attachment
5. Select a video
6. Send the video
7. Long press on the message with text and video
8. Tap Edit comment

Expected Result:

App will not crash

Actual Result:

App crashes on iOS app
Console error shows up on web app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6551451_1721820850558.ScreenRecording_07-24-2024_19-31-04_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2f80c595cce99e8
• Upwork Job ID: 1816209661264574315
• Last Price Increase: 2024-07-24
• Automatic offers:
• ZhenjaHorbach | Reviewer | 103271953
• nkdengineer | Contributor | 103271954

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2f80c595cce99e8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on iOS app
Console error shows up on web app

What is the root cause of that problem?

In https://github.com/Expensify/react-native-live-markdown/blob/ff55579f673c049a6eb6cdf38ffc223315309b07/parser/index.ts#L194, we don't have code to parseTreeToTextAndRanges for video tag yet. So it throws error here

What changes do you think we should make in order to solve the problem?

Add code to parseTreeToTextAndRanges for video tag here, it's quite similar to img tag.

Pseudocode for it:

else if (node.tag.startsWith('<video data-expensify-source="')) {
    const src = node.tag.match(/data-expensify-source="([^"]*)"/)![1]!; // always present
    const rawLink = node.tag.match(/data-raw-href="([^"]*)"/);
    const linkString = rawLink ? Utils.unescapeText(rawLink[1]!) : src;
    const attachmentName = node.children?.join('')?.replaceAll('&#32;', ' ');

    appendSyntax('!');
    if (attachmentName) {
      appendSyntax('[');
      processChildren(Utils.unescapeText(attachmentName || ''));
      appendSyntax(']');
    }
    appendSyntax('(');
    addChildrenWithStyle(linkString, 'link');
    appendSyntax(')');
  }

What alternative solutions did you explore? (Optional)

[ZhenjaHorbach]

As additional information: