[HOLD for payment 2024-08-19] [$250] LHN – Concierge chat opens when change priority mode to Most recent

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4761236&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers): gocemate+a686@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login with new gmail account
2. Go to Account settings> Preferences> Focus
3. Go to Account settings> Preferences> Most recent

Expected Result:

User should stay on Preferences page

Actual Result:

User navigates to Concierge chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6551399_1721815858022.Recording__3548.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cd28acd2df01cf0e
• Upwork Job ID: 1816460956793747307
• Last Price Increase: 2024-07-25
• Automatic offers:
• DylanDylann | Reviewer | 103326560
• nkdengineer | Contributor | 103326561

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[francoisl]

Hm interestingly, it doesn't happen if you already have multiple chats or rooms. Doesn't seem like something worth blocking for, going to demote.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User navigates to Concierge chat

What is the root cause of that problem?

When the onboarding data is changed we resolve the onboarding value here. If we log in with a new account and complete the onboarding flow and then isOnboardingFlowCompleted the second time, isOnboardingFlowStatusKnownPromise promise will return the onboarding data to the old data because after we complete the onboarding flow, the onboarding data is changed and we don't reset the isOnboardingFlowStatusKnownPromise promise.

App/src/libs/actions/Welcome.ts

Line 178 in b0f810d

resolveOnboardingFlowStatus(value);

The problem happens when we change the priority mode from focus to recent, we have a logic here to call the OpenApp API again.

App/src/libs/actions/App.ts

Lines 72 to 76 in b0f810d

	if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) {
	// eslint-disable-next-line @typescript-eslint/no-use-before-define
	openApp();
	}
	priorityMode = nextPriorityMode;

It leads isLoadingApp changing and this useEffect is triggered again. As I explained above because the onboarding data is the old data onNotCompleted callback is called and the navigation state is reset. Then the concierge chat is opened as the recent chat.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 59 to 63 in b0f810d

	Welcome.isOnboardingFlowCompleted({
	onNotCompleted: () => {
	const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT, linkingConfig.config);
	navigationRef.resetRoot(adaptedState);
	},

What changes do you think we should make in order to solve the problem?

We should reset the isOnboardingFlowStatusKnownPromise promise when the onboarding data is changed

isOnboardingFlowStatusKnownPromise = new Promise<OnboardingData>((resolve) => {
    resolveOnboardingFlowStatus = resolve;
});
resolveOnboardingFlowStatus(value);

App/src/libs/actions/App.ts

Lines 72 to 76 in b0f810d

	if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) {
	// eslint-disable-next-line @typescript-eslint/no-use-before-define
	openApp();
	}
	priorityMode = nextPriorityMode;

What alternative solutions did you explore? (Optional)

Or we can revert the change in this PR #45327 to use an onboarding variable and update it every time the onboarding data changes.

App/src/libs/actions/App.ts

Lines 72 to 76 in b0f810d

	if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) {
	// eslint-disable-next-line @typescript-eslint/no-use-before-define
	openApp();
	}
	priorityMode = nextPriorityMode;