[HOLD for payment 2024-08-13] [HOLD for payment 2024-08-07] [$250] Split - Split amount shows 0.00 in LHN when splitting an expense with no chat history

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Sign in to staging (Let's call this user A)
3. Click on FAB
4. Click on split expense
5. Enter an amount and click next
6. Enter a user you have never chatted with before (Let's call this user user B)
7. Click on next and finish the flow
8. Sign in as user B
9. Before opening the chat with user A observe the chat preview in LHN
   (Important : Make sure that you haven't opened the chat with user A)

Expected Result:

The split expense preview in LHN shows the correct split amount

Actual Result:

The split expense amount in the LHN message preview shows 0.00 (Message preview is "User B owes 0.00)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6548229_1721493192166.2024-07-20_19_08_12.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01756b0cd389a7093c
• Upwork Job ID: 1815485176933143349
• Last Price Increase: 2024-07-22
• Automatic offers:
• brunovjk | Reviewer | 103254818
• tsa321 | Contributor | 103254819

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[tsa321]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split - Split amount shows owes 0.00 in LHN when splitting an expense with no chat history and after all expense paid.

What is the root cause of that problem?

Here

App/src/components/LHNOptionsList/OptionRowLHNData.tsx

Lines 62 to 69 in 0673b9b

	}, [
	fullReport,
	lastReportActionTransaction,
	reportActions,
	personalDetails,
	preferredLocale,
	policy,
	parentReportAction,

The OptionRowLHNData / OptionItem depends only on the reportActions which is itemReportActions (which is the reportActions of report of the option item set by OptionRowLHNData) and the parentReportActions.
When user receive split bills message:

App/src/libs/OptionsListUtils.ts

Lines 699 to 708 in 0673b9b

	const iouReport = getReportOrDraftReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastReportAction));
	const lastIOUMoneyReportAction = allSortedReportActions[iouReport?.reportID ?? '-1']?.find(
	(reportAction, key): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> =>
	ReportActionUtils.shouldReportActionBeVisible(reportAction, key) &&
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	ReportActionUtils.isMoneyRequestAction(reportAction),
	);
	const reportPreviewMessage = ReportUtils.getReportPreviewMessage(
	!isEmptyObject(iouReport) ? iouReport : null,
	lastIOUMoneyReportAction,

the getReportPreviewMessage won't get the correct message, because lastIOUMoneyReportAction is undefined. This is because onyxUpdates from pusher isn't completed yet. When the onyxUpdates completed the OptionItem won't re-render because it doesn't depend on the reportActions of the iouReport. So it will stay 0.00, until the user receive new messages or user navigate to other report, which will re-render the LHNData.

In the code at:

App/src/components/LHNOptionsList/OptionRowLHNData.tsx

Lines 62 to 69 in 0673b9b

	}, [
	fullReport,
	lastReportActionTransaction,
	reportActions,
	personalDetails,
	preferredLocale,
	policy,
	parentReportAction,

)

the OptionRowLHNData or OptionItem relies on reportActions which is itemReportActions (which is the reportActions of the report associated with the option item set by OptionRowLHNData-- so it is not allReportActions), and parentReportActions.

When a user receives a split bill message, as detailed

App/src/libs/OptionsListUtils.ts

Lines 699 to 708 in 0673b9b

	const iouReport = getReportOrDraftReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastReportAction));
	const lastIOUMoneyReportAction = allSortedReportActions[iouReport?.reportID ?? '-1']?.find(
	(reportAction, key): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> =>
	ReportActionUtils.shouldReportActionBeVisible(reportAction, key) &&
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	ReportActionUtils.isMoneyRequestAction(reportAction),
	);
	const reportPreviewMessage = ReportUtils.getReportPreviewMessage(
	!isEmptyObject(iouReport) ? iouReport : null,
	lastIOUMoneyReportAction,

the getReportPreviewMessage function does not retrieve the correct message because lastIOUMoneyReportAction is undefined. This occurs because the onyxUpdates from Pusher have not completed yet. Once the onyxUpdates are complete, the OptionItem does not re-render because it does not depend on the reportActions of the iouReport. As a result, it will continue to display 0.00 until the user receives new messages or navigates to another report, triggering a re-render of the LHNData.

What changes do you think we should make in order to solve the problem?

We should add a dependency for the OptionItem to rely on the reportActions of the IOUReport or reports that are associated with the last message of the item's report. To achieve this, we could create utility functions in OptionsListUtils to retrieve the relevant report IDs (in this issue it is the iouReport.reportID).

The code could be:

function getIOUReportIDOfLastAction(report) {
    const lastAction = visibleReportActionItems[report.reportID];
    if (ReportActionUtils.isReportPreviewAction(lastAction)) {
        return getReportOrDraftReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastAction))?.reportID;
    }
}

We could name it getIOUReportIDOfLastAction. If we need more generalized report IDs, we could name it getReportIDsRelatedToLastAction.

Then in LHNOptionList, within renderItem, we would then add:

const iouReportIDOfLastAction = OptionsListUtils.getIOUReportIDOfLastAction(itemFullReport);
const itemIouReportReportActions = !!iouReportIDOfLastAction ? reportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReportIDOfLastAction}`] : undefined;

This addition ensures that the OptionItem appropriately depends on relatedReportIDsReportActions or in this issue: iouReportReportActions.

Next, add itemIouReportReportActions to the properties of OptionRowLHNData. Then, within the useMemo of OptionItem, include IOUReportReportActions as a dependency.

Result:

macos-web-d.mp4

Result

Alternative solutions

We could add dependency of the OptionItem to depend on all report actions, but this is very inefficient

[Christinadobrzyn]

I'm not able to reproduce this, I see the correct amount in the LHN of the split user.

I'll ask QA for some more details on how to reproduce this. #45855

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[kavimuru]

1. Sign in as User A
2. Sign in as user B in another browser or in cognito
3. As user A split expense with User B (Make sure that the users have no previous chat history)
4. After the split expense is created observe the LHN in the tab where you are logged in as user B (Before opening the chat)

2024-07-22.22.53.33.mp4

[Christinadobrzyn]

I'm not getting the same results - I see the actual amount that was split in the LHN but it sounds like QA has been able to reproduce this so we'll keep moving it forward.

Starting with this as an external job