[HOLD for payment 2024-08-09] [$250] Incorrect report action message when changing the "Reimbursable"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721309857362059

Action Performed:

1. Submit an expense to approver
2. As approver, login to OldDot
3. Open the submitted report
4. change the reimbursable to non reimbursable expense by checking off the box
5. Go to NewDot and open the report

Expected Result:

Report action should be related to changing Reimbursable

Actual Result:

"Changed Expense" report action appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Recording.366.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011c572749229de53f
• Upwork Job ID: 1815864020389627404
• Last Price Increase: 2024-07-23

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursable change is not reflected in modified expense report action.

What is the root cause of that problem?

We currently did not implement Reimbursable change for MODIFIED_EXPENSE report actions.

App/src/libs/ModifiedExpenseMessage.ts

Line 108 in 5a2602c

function getForReportAction(reportID: string | undefined, reportAction: OnyxEntry<ReportAction>): string {

What changes do you think we should make in order to solve the problem?

Reimbursable change is indicated by reimbursable and oldReimbursable within originalMessage. We can follow the same steps with other fields' changes.

1. Define those 2 fields in OriginalMessageModifiedExpense type:

App/src/types/onyx/OriginalMessage.ts

Line 256 in 6a7c057

type OriginalMessageModifiedExpense = {

2. Write logic for it in getForReportAction above:

const hasModifiedReimbursable = reportActionOriginalMessage && 'oldReimbursable' in reportActionOriginalMessage && 'reimbursable' in reportActionOriginalMessage;
if (hasModifiedReimbursable) {
    buildMessageFragmentForValue(
        String(reportActionOriginalMessage?.reimbursable) ?? '',
        String(reportActionOriginalMessage?.oldReimbursable) ?? '',
        Localize.translateLocal('iou.expense'),
        true,
        setFragments,
        removalFragments,
        changeFragments,
    );
}

And it says changed the expense to "false" (previously "true"). We can change the copy if needed.

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011c572749229de53f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)