[HOLD for payment 2024-08-14] [$250] Multi tags - Unable to save GL code for dependant tags

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace is under Control plan
• Workspace is imported with dependant tags on Old Dot

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags
3. Click on any tag
4. Click on any subtag
5. Click GL code
6. Enter the GL code and save it
7. Click on the same subtag again

Expected Result:

GL code will be saved

Actual Result:

User is unable to save GL code for dependant tags

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547112_1721389126489.20240719_192901.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d849cbdc023dce84
• Upwork Job ID: 1818145196845810989
• Last Price Increase: 2024-07-30
• Automatic offers:
• brunovjk | Reviewer | 103339974
• gijoe0295 | Contributor | 103339976

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is unable to save GL code for multilevel tags

What is the root cause of that problem?

The tag list name here is not retrieved properly:

App/src/libs/actions/Policy/Tag.ts

Line 775 in fa738c6

const tagListName = Object.keys(allPolicyTags?.[`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`] ?? {})[tagListIndex];

The tagListIndex is indeed the orderWeight of the tag list, we should filter the policy tags based on orderWeight instead of directly using the list index.

We should only use direct list index access when we call getTagList which already sorts the list based on orderWeight:

App/src/libs/PolicyUtils.ts

Line 268 in ad6cbeb

.sort((tagA, tagB) => tagA.orderWeight - tagB.orderWeight);

App/src/libs/actions/Policy/Tag.ts

Line 412 in fa738c6

const tagList = PolicyUtils.getTagLists(allPolicyTags?.[`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`] ?? {})?.[tagListIndex] ?? {};

What changes do you think we should make in order to solve the problem?

Use PolicyUtils.getTagListName as we have been using elsewhere:

App/src/pages/iou/request/step/IOURequestStepTag.tsx

Line 68 in 99f7544

const policyTagListName = PolicyUtils.getTagListName(policyTags, tagListIndex);

[melvin-bot]

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[gijoe0295]

@anmurali Can you take a look?

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali Still overdue 6 days?! Let's take care of this!