[$250] Tax code - Error shows up when attempting to save tax code without modifying it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace is under Control plan

1. Go to staging.new.expensify.com
2. Go to Workspace settings > Taxes
3. Click on any tax
4. Click Tax code
5. Without modifying the existing tax code, save the tax code

Expected Result:

User will be able to save existing tax code when no changes are made

Actual Result:

Error shows up when attempting to save tax code without modifying it - This tax code is already in use

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547141_1721391649811.20240719_201838.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0100ee19e52f8bb5b6
• Upwork Job ID: 1814285898085752540
• Last Price Increase: 2024-07-19

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error shows up when attempting to save tax code without modifying it

What is the root cause of that problem?

On submit, we call validateTaxCode passing current input value and policy as params. And validateTaxCode, compares current value with existing tax code keys and returns error when finding a matching key in policy.taxRates.taxes

App/src/pages/workspace/taxes/WorkspaceTaxCodePage.tsx

Lines 50 to 55 in b8b99d0

	const validate = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_TAX_CODE_FORM>) => {
	if (!policy) {
	return {};
	}
	return validateTaxCode(policy, values);

What changes do you think we should make in order to solve the problem?

We should check if the input value is equal to the currentTaxCode tax code. Then return empty object if they are equal before returning result of validateTaxCode(policy, values);

if (values?.taxCode.trim() === currentTaxCode) return {};
return validateTaxCode(policy, values);

What alternative solutions did you explore? (Optional)

[trjExpensify]

@dangrous @Gonals @rushatgabhane @dylanexpensify - heads up!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0100ee19e52f8bb5b6