[HOLD for payment 2024-08-14] [$250] Categories - Toggle, GL code & Payroll code are no longer grayed out after renaming category

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4737496
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace is under Control plan.

1. Go to staging.new.expensify.com
2. Go offline
3. Go to workspace settings
4. Go to Categories.
5. Click on any category.
6. Click on the toggle, edit GL code and Payroll code.
7. Note that the options gray out.
8. Click on the category name.
9. Rename the category and save it.

Expected Result:

The toggle, GL code and Payroll code will remain grayed out after renaming the category.

Actual Result:

The toggle, GL code and Payroll code are no longer grayed out after renaming the category.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6546452_1721324098872.20240719_013203.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01432f0d4ba1a79d10
• Upwork Job ID: 1815330505338838748
• Last Price Increase: 2024-07-22
• Automatic offers:
• rayane-djouah | Reviewer | 103234421

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #wave-control

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Toggle, GL code & Payroll code are no longer grayed out after renaming category

What is the root cause of that problem?

We are reseting pendingFields of the category we are editing to name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE. This discards GL code and Payroll code pendingFields.

App/src/libs/actions/Policy/Category.ts

Lines 283 to 285 in eb6ca6d

	pendingFields: {
	name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},

What changes do you think we should make in order to solve the problem?

We should spread policyCategoryToUpdate?.pendingFields in pendingFields below

pendingFields: {
                            ...policyCategoryToUpdate?.pendingFields,
                            name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                        },

App/src/libs/actions/Policy/Category.ts

Lines 283 to 285 in eb6ca6d

	pendingFields: {
	name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - Toggle, GL code & Payroll code are no longer grayed out after renaming category

What is the root cause of that problem?

In renamePolicyCategory function we aren't merging the existing pending fields in onyx data. Additionally the errors should be also set to null when renaming category like we do when renaming tag.

App/src/libs/actions/Policy/Category.ts

Lines 283 to 285 in 54fdb24

	pendingFields: {
	name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},

App/src/libs/actions/Policy/Category.ts

Lines 302 to 304 in 54fdb24

	pendingFields: {
	name: null,
	},

App/src/libs/actions/Policy/Tag.ts

Lines 425 to 434 in 54fdb24

	[newTagName]: {
	...tag,
	name: newTagName,
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	pendingFields: {
	...tag.pendingFields,
	name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	previousTagName: oldTagName,
	errors: null,

What changes do you think we should make in order to solve the problem?

We need to clear the errors (errors: null) in optimistic data and spread the existing pending fields (...policyCategoryToUpdate.pendingFields) in optimistic data and success data.

App/src/libs/actions/Policy/Category.ts

Lines 279 to 287 in 54fdb24

	[policyCategory.newName]: {
	...policyCategoryToUpdate,
	name: policyCategory.newName,
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	pendingFields: {
	name: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	previousCategoryName: policyCategory.oldName,
	},

App/src/libs/actions/Policy/Category.ts

Lines 302 to 304 in 54fdb24

	pendingFields: {
	name: null,
	},

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01432f0d4ba1a79d10

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)