[HOLD for payment 2024-08-09] [$250] Draft disappears from the LHN when clicking away after starting a thread

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.8-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721142729468189

Action Performed:

1. Create a group as user A with user B and user C
2. Send a message to group as user A
3. Start a thread as user B
4. Without joining click away

Expected Result:

Draft should stay in the LHN

Actual Result:

Draft disappear from the LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.345.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011241d6b36d075893
• Upwork Job ID: 1815808765453560667
• Last Price Increase: 2024-07-23
• Automatic offers:
• mkhutornyi | Reviewer | 103252123
• nkdengineer | Contributor | 103252124

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Draft disappear from the LHN

What is the root cause of that problem?

The thread report has notificationPreference as hidden. If we don't open this thread or this thread is not pinned, it's hidden in LHN because we return early here.

App/src/libs/SidebarUtils.ts

Line 136 in 9c509a0

const shouldOverrideHidden = hasErrorsOtherThanFailedReceipt || isFocused || isSystemChat || report.isPinned;

App/src/libs/SidebarUtils.ts

Lines 137 to 139 in 9c509a0

	if (isHidden && !shouldOverrideHidden) {
	return;
	}

What changes do you think we should make in order to solve the problem?

If the report has a draft comment shouldOverrideHidden should be true. We should use hasValidDraftComment to check whether the report has a draft comment or not.

const shouldOverrideHidden = hasErrorsOtherThanFailedReceipt || isFocused || isSystemChat || report.isPinned || hasValidDraftComment(report.reportID);

App/src/libs/SidebarUtils.ts

Line 136 in 9c509a0

const shouldOverrideHidden = hasErrorsOtherThanFailedReceipt || isFocused || isSystemChat || report.isPinned;

Then the check shouldReportBeInOptionList can be called and everything works well because we already have the check for draft comment in this function

https://github.com/Expensify/App/blob/9c509a0e6363adaeb6cbb8c377ed6ff98b85dc65/src/libs/ReportUtils.ts#L5486-5487

What alternative solutions did you explore? (Optional)

We can return early if the report has a draft comment before this line

if (hasValidDraftComment(report.reportID)) {
    reportsToDisplay.push(report);
    return;
}

App/src/libs/SidebarUtils.ts

Line 136 in 9c509a0

const shouldOverrideHidden = hasErrorsOtherThanFailedReceipt || isFocused || isSystemChat || report.isPinned;

[melvin-bot]

@abekkala Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011241d6b36d075893

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)